Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: developers menu item highlighting issue, fix#439" #459

Merged
merged 1 commit into from Mar 17, 2020

Conversation

@lovepoem
Copy link
Collaborator

lovepoem commented Mar 17, 2020

Reverts #457

(node:2776) UnhandledPromiseRejectionWarning: SecurityError: localStorage is not available for opaque origins
at Window.localStorage (/home/runner/work/wuhan2020.github.io/wuhan2020.github.io/node_modules/jsdom/lib/jsdom/browser/Window.js:257:15)
at new GitalkComponent (/home/runner/work/wuhan2020.github.io/wuhan2020.github.io/node_modules/gitalk/dist/webpack:/gitalk.jsx:84:34)
at processChild (/home/runner/work/wuhan2020.github.io/wuhan2020.github.io/node_modules/react-dom/cjs/react-dom-server.node.development.js:2995:14)
at resolve (/home/runner/work/wuhan2020.github.io/wuhan2020.github.io/node_modules/react-dom/cjs/react-dom-server.node.development.js:2960:5)
at ReactDOMServerRenderer.render (/home/runner/work/wuhan2020.github.io/wuhan2020.github.io/node_modules/react-dom/cjs/react-dom-server.node.development.js:3435:22)
at ReactDOMServerRenderer.read (/home/runner/work/wuhan2020.github.io/wuhan2020.github.io/node_modules/react-dom/cjs/react-dom-server.node.development.js:3373:29)
at Object.renderToString (/home/runner/work/wuhan2020.github.io/wuhan2020.github.io/node_modules/react-dom/cjs/react-dom-server.node.development.js:3988:27)
at files.forEach.file (/home/runner/work/wuhan2020.github.io/wuhan2020.github.io/node_modules/docsite/lib/generateJSONFile.js:87:38)
at Array.forEach ()
at parse (/home/runner/work/wuhan2020.github.io/wuhan2020.github.io/node_modules/docsite/lib/generateJSONFile.js:39:11)
(node:2776) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:2776) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
/home/runner/work/wuhan2020.github.io/wuhan2020.github.io/sitemap-generator.js:19
items.forEach(function (item) {
^

TypeError: Cannot read property 'forEach' of undefined
at /home/runner/work/wuhan2020.github.io/wuhan2020.github.io/sitemap-generator.js:19:11
at FSReqWrap.args [as oncomplete] (fs.js:140:20)
##[error]Process completed with exit code 1.

@lovepoem lovepoem requested a review from wuhan2020/team-translate as a code owner Mar 17, 2020
@menbotics menbotics bot added the kind/bug label Mar 17, 2020
@lovepoem lovepoem merged commit 6a5f474 into dev Mar 17, 2020
6 checks passed
6 checks passed
audit
Details
Build (10.x)
Details
calibreapp/image-actions calibreapp/image-actions
Details
DeepScan 0 new and 0 fixed issues for 3 projects
Details
WIP Ready for review
Details
codebeat 1 issue resolved and 1 introduced
Details
@lovepoem lovepoem deleted the revert-457-fix-menu-highlighting-issue branch Mar 17, 2020
lovepoem added a commit that referenced this pull request Mar 17, 2020
lovepoem added a commit that referenced this pull request Mar 17, 2020
…#457)" (#459)" (#460)

This reverts commit 6a5f474.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.