Skip to content

Commit

Permalink
Fix git-rev-list "date order" with --topo-order
Browse files Browse the repository at this point in the history
This fixes git-rev-list so that when there are multiple branches, we still
sort the heads in proper approximate date order even when sorting the
output topologically.

This makes things like

	gitk --all -d

work sanely and show the branches in date order (where "date order" is
obviously modified by the paren-child dependency requirements of the
topological sort).

The trivial fix is to just build the "work" list in date order rather than
inserting the new work entries at the beginning.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Linus Torvalds authored and Junio C Hamano committed Nov 14, 2005
1 parent d4072c9 commit 2ed0288
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions commit.c
Expand Up @@ -536,7 +536,7 @@ int count_parents(struct commit * commit)
void sort_in_topological_order(struct commit_list ** list)
{
struct commit_list * next = *list;
struct commit_list * work = NULL;
struct commit_list * work = NULL, **insert;
struct commit_list ** pptr = list;
struct sort_node * nodes;
struct sort_node * next_nodes;
Expand Down Expand Up @@ -580,11 +580,12 @@ void sort_in_topological_order(struct commit_list ** list)
* the tips serve as a starting set for the work queue.
*/
next=*list;
insert = &work;
while (next) {
struct sort_node * node = (struct sort_node *)next->item->object.util;

if (node->indegree == 0) {
commit_list_insert(next->item, &work);
insert = &commit_list_insert(next->item, insert)->next;
}
next=next->next;
}
Expand Down

0 comments on commit 2ed0288

Please sign in to comment.