Pixelbook fixes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This write does not seem correct, Linux and OpenBSD do not do this. The Google Pixelbook (eve)'s touchpad (rose) was going off the rails (i.e. screwing up the whole i2c bus) because of this write.
The Google Pixelbook (eve)'s touchpad (rose) did not understand the two writes and did not switch into multitouch mode.
wulf7
approved these changes
Sep 11, 2019
|
|
Yes! Works fine, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the Google Pixelbook touchpad :) See commit messages.
Gestures work, tap works, tap and drag works, only physical click doesn't work, but the physical click on this device sucks anyway.
(the no-two-writes commit is not very good code, feel free to do whatever you feel is better code style - append the buf into cmd, etc.)