Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen should select the current screen display #729

Closed
kud opened this issue Oct 1, 2019 · 4 comments

Comments

@kud
Copy link

commented Oct 1, 2019

macOS version: 10.14.6
Kap version: 2.2.0 (2.2.0.880)

When you've got multiple screen displays and you click on kap.app on the current display screen you want, "fullscreen" always selects the Display 1, not the screen display you clicked on the task bar.

@skllcrn

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Hi @kud, please complete the issue template including your macOS and Kap version. We'll label the issue, so no need to include that in the title. Thank you!

@kud

This comment has been minimized.

Copy link
Author

commented Oct 7, 2019

macOS version: 10.14.6
Kap version: 2.2.0 (2.2.0.880)

Steps to reproduce

image

Current behaviour

It takes the Display 1, always

Expected behaviour

It could/should take the display where you click on the systray or at least ask the user to choose the display wanted.

Workaround

None. See how Cleanshot.app does, it works well.

  • macOS: 10.14.6
  • Kap: 2.2.0 (2.2.0.880)
@skllcrn skllcrn changed the title [Bug] fullscreen should select the current screen display Fullscreen should select the current screen display Oct 7, 2019
@skllcrn

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Thanks again @kud. In this issue we'll discuss the behaviour of the fullscreen toggle, and we can discuss extending its functionality in the separate issue you created: #728

If I recall correctly, the intended behaviour here is to crop the active display if nothing else is defined. Can you test the latest Kap beta release to see if that is the case for you?

@kud

This comment has been minimized.

Copy link
Author

commented Oct 7, 2019

It's more than ok with the latest beta yes, thank you!

@kud kud closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.