Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial width and height of cropper #570

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@masquel
Copy link

commented Oct 4, 2018

Closes #556

@albinekb
Copy link
Collaborator

left a comment

Nice! 👍

width: width || 0,
height: height || 0,
width: width || 400,
height: height || 400,
ratio: ratio || [1, 1]

This comment has been minimized.

Copy link
@skllcrn

skllcrn Oct 4, 2018

Member

I suggest setting the initial/default aspect ratio to 4:3, that aspect ratio works better across devices and services you're likely to upload to.

width: width 400,
height: height 300,
ratio: ratio [4, 3]

@skllcrn skllcrn changed the title fix #556 set initial width and height of cropper to 400px Set initial width and height of cropper Oct 4, 2018

@masquel

This comment has been minimized.

Copy link
Author

commented Oct 4, 2018

done

@skllcrn

skllcrn approved these changes Oct 4, 2018

@sindresorhus

This comment has been minimized.

Copy link
Member

commented Oct 4, 2018

I don't think I was clear enough in #556. I meant we should set a larger initial size of the cropper after choosing an aspect ratio in the dropdown, not should show the cropper rectangle by default on startup.

@skllcrn skllcrn requested review from karaggeorge and sindresorhus Oct 21, 2018

@sindresorhus

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

@masquel Still interested in finishing this? :)

@sindresorhus

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

Closing for lack of activity. Happy to reopen if you get around to finishing this :)

@masquel

This comment has been minimized.

Copy link
Author

commented May 5, 2019

@sindresorhus hello, so what do you want now for the initial size?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.