Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `electron-store` JSON schema for the app settings #667

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
4 participants
@blakedietz
Copy link
Contributor

commented May 1, 2019

Adds a JSON schema for electron-store.

re #663

refactor(settings.js): Add electron-store schema
Adds a JSON schema for electron-store.

re #663

@skllcrn skllcrn requested review from karaggeorge, albinekb and sindresorhus May 2, 2019

@sindresorhus sindresorhus changed the title refactor(settings.js): Add electron-store schema Add `electron-store` JSON schema for the app settings May 2, 2019

@skllcrn skllcrn merged commit 0e1e4af into wulkano:master May 2, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
@blakedietz

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

@sindresorhus how can I snag the issuehunt deposit for completing this issue?

@sindresorhus

This comment has been minimized.

Copy link
Member

commented May 3, 2019

@blakedietz Done now. Rewarding is done manually.

@blakedietz

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

@sindresorhus thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.