fix: introspection query detection#1259
Merged
Merged
Conversation
devsergiy
approved these changes
Oct 10, 2024
jensneuse
added a commit
that referenced
this pull request
May 23, 2026
… APIs Pins github.com/wundergraph/graphql-go-tools/v2 to commit 590f6779 (branch feat/add-caching-support) which contains the request-scoped widening fix (commit 85fb34e388). Enables the previously-skipped TestEntityCaching/L1/request-scoped_widening_refetch. Adaptations forced by the bump: - LoaderCache.Set: TTL moved from a call argument to a per-entry CacheEntry.TTL field. memory/redis/circuit_breaker caches and all callers updated. - SubscriptionResponseWriter: Close(kind) replaced by Error(data). HttpFlushWriter.Close removed; websocketResponseWriter.Error writes the error payload via the existing WriteGraphQLErrors path. - SubscriptionUpdater: Complete()/Done()/Error(data) split replaces the old Close(kind). Cosmo's SubscriptionEventUpdater wrapper pairs Complete with Done; CloseSubscription drops the kind argument. Mocks regenerated. - ResolveGraphQLResponse gained a new []byte data parameter; switched cosmo call sites to ArenaResolveGraphQLResponse which preserves the old 3-arg shape. - VariablesView: cost calculator and arg validators now take a resolve.VariablesView value. Built via resolve.NewVariablesView at cosmo call sites. - ConnectionID is now a typed alias; ConnectionIDs.Inc() became resolve.NewConnectionID(). AsyncCompleteSubscription / AsyncUnsubscribeClient renamed to UnsubscribeSubscription / UnsubscribeClient. - graphql_datasource subscription client uses functional options; NetPollConfiguration, WithReadTimeout, WithFrameTimeout removed upstream. ReadTimeout / FrameTimeout cosmo YAML fields are now silently inert (kept for back-compat); EnableNetPoll still drives cosmo's own netpoller. - plan.FieldWeight renamed to plan.FieldCost. - UpgradeRequestError / InvalidWsSubprotocolError moved to the subscriptionclient package as ErrFailedUpgrade / ErrInvalidSubprotocol. Tests: - All 60 router-tests/entity_caching tests pass. - Combined/L1_deduplicates_with_warm_L2 cache.Len() expectation raised from 1 to 2 to track the upstream bulk-L2-Set behavior change from commit 2427062b1f; L1 dedup behavior (counters.details == 1) is unchanged. - router/pkg/pubsub/datasource and router/pkg/entitycache unit tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO