Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/redirects #18

Merged
merged 4 commits into from May 7, 2020
Merged

Feature/redirects #18

merged 4 commits into from May 7, 2020

Conversation

Jancis
Copy link
Member

@Jancis Jancis commented May 6, 2020

Redirect functionality from drupal chart (wunderio/charts@8e5ebbf)

@Jancis Jancis requested a review from floretan May 6, 2020 12:11
@floretan
Copy link
Contributor

floretan commented May 7, 2020

@Jancis I would leave the example in the silta.yml for this project.

@Jancis
Copy link
Member Author

Jancis commented May 7, 2020

Example redirect added. One that forwards / to /hello

nginx:
  redirects:
    - description: 'Redirect main path to default service (exact match)'
      from: /
      to: /hello

As stated, It's an exact match, does not affect subpaths with trailing slash:

# curl https://feature-redirects.frontend-project-k8s.silta.wdr.io/ -I      
HTTP/2 301 
location: http://feature-redirects.frontend-project-k8s.silta.wdr.io/hello

# curl https://feature-redirects.frontend-project-k8s.silta.wdr.io/hello/ -I
HTTP/2 200 

Copy link
Contributor

@floretan floretan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the update!

@floretan floretan merged commit 2ed6bbd into master May 7, 2020
@floretan floretan deleted the feature/redirects branch May 7, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants