Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Users don't think of scrolling down to see results #34

Closed
yannickwurm opened this Issue · 6 comments

3 participants

@yannickwurm
Owner

Skype extract:
"17:37
after I clicked "blast" button
17:37
it resets everything
17:37
no result, just look like before I pasted the seq"

Basically the user didn't see that the blast result had appeared at the bottom of the window. Probably because she doesn't have a 24 inch screen...
Somehow we need to make the UI clearer.

Resolving this will require coordination with #30

@yeban
Owner

+1. I had been meaning to do this for sometime now.

@wwood
Collaborator

Just add a HTML within-page anchor #results and then go there when people click on the get results button?

@yeban yeban referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@yeban yeban referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@yeban
Owner

sha: bb9e38c is horrendous. don't know what I was thinking while making that commit :P.

@yeban
Owner

sha: 963a3fd works on FF, and Chrome.

@yeban yeban closed this issue from a commit
@yeban yeban automatically scroll down to the blast results (closes #34)
This _should_ have a more uniform behavior (w.r.t history and stuff)
across all browsers than changing location.hash via JS. And is much
simpler.

Tested on FF, and Chrome.
7e93e99
@yeban yeban closed this in 7e93e99
@yannickwurm
Owner

very elegant solution!

@yeban yeban reopened this
@yeban
Owner

This fails sometimes. I had used url fragments, so we don't have to resort to JS unnecessarily, hoping it would work across all browsers (with or without JS). Sadly, Firefox with JS disabled doesn't scroll down to results. Hence re-opening this issue.

@yeban yeban closed this issue from a commit
Commit has since been removed from the repository and is no longer available.
@yeban yeban closed this in d11e476
@yeban yeban referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@yeban yeban referenced this issue from a commit in yeban/sequenceserver
@yeban yeban reset location.hash when user submits a BLAST request (close #34)
Once the BLAST results are available users shouldn't have to scroll down
themselves to see the result.  SS does this by setting location.hash to
'result' once the BLAST results have been fetched causing browser to jump
to the BLAST results.

Now, if users need to re-blast, they will have to go back to the search form,
edit parameters, and click BLAST.  There are three ways a user can go back to
the search form: scroll up, refresh page, hit back button.  `location.hash` is
retained in the first two approach.  And browsers don't react if one tries to
set `location.hash` to the same value that it holds.  So SS wouldn't jump to
results for the second time if the user scrolled up, or did a page refresh to
get back to the search form, after viewing the results.  Instead SS would stay
at the current scroll location.

As a workaround, SS now resets `location.hash` to '' when user clicks BLAST.
And sets it back to 'result', as usual, when BLAST results are available.
Effectively, SS should always _jump_ to results after a successful BLAST.

Signed-off-by: Anurag Priyam <anurag08priyam@gmail.com>
03e9d55
@yeban yeban referenced this issue from a commit
@yeban yeban Reset location.hash when user submits a BLAST request (close #34).
Once the BLAST results are available users shouldn't have to scroll down
themselves to see the result.  SS does this by setting location.hash to
'result' once the BLAST results have been fetched causing browser to jump
to the BLAST results.

Now, if users need to re-blast, they will have to go back to the search form,
edit parameters, and click BLAST.  There are three ways a user can go back to
the search form: scroll up, refresh page, hit back button.  `location.hash` is
retained in the first two approach.  And browsers don't react if one tries to
set `location.hash` to the same value that it holds.  So SS wouldn't jump to
results for the second time if the user scrolled up, or did a page refresh to
get back to the search form, after viewing the results.  Instead SS would stay
at the current scroll location.

As a workaround, SS now resets `location.hash` to '' when user clicks BLAST.
And sets it back to 'result', as usual, when BLAST results are available.
Effectively, SS should always _jump_ to results after a successful BLAST.

Signed-off-by: Anurag Priyam <anurag08priyam@gmail.com>
992cdc6
@yeban yeban referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@yeban yeban referenced this issue from a commit in yeban/sequenceserver
@yeban yeban Release 0.8.2.
* Tighten dependency.
* Print version number on `sequenceserver -v`.
* Reset location.hash when user submits a BLAST request (close #34).

Signed-off-by: Anurag Priyam <anurag08priyam@gmail.com>
3ad526a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.