New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions to work with triggeraction & triggercondition #102

Merged
merged 2 commits into from Aug 7, 2018

Conversation

Projects
None yet
3 participants
@Rhazarian
Copy link
Contributor

Rhazarian commented Aug 7, 2018

These functions allow to use triggeraction & triggercondition in generics. It can be useful, e.g. if you manage triggers dynamically and want to remove actions and conditions to avoid leaks

Rhazarian added some commits Aug 7, 2018

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Aug 7, 2018

Hi, thanks for your contribution.
Is this your last three PRs combined or what was the deal with closing them instantly?
Looks good to me.

@Rhazarian

This comment has been minimized.

Copy link
Contributor Author

Rhazarian commented Aug 7, 2018

Yes, it's those combined. The reason was that they weren't able to build separately because they depend on each other, actually pulling them in such a way was a mistake.

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Aug 7, 2018

Good stuff 💎

@Frotty Frotty merged commit 21900a5 into wurstscript:master Aug 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Cokemonkey11

This comment has been minimized.

Copy link
Contributor

Cokemonkey11 commented Aug 7, 2018

The reason was that they weren't able to build separately because they depend on each other, actually pulling them in such a way was a mistake.

You probably could have just had them reviewed/accepted in order (they don't depend on each other - just one depends on the other)

Anyway lgtm thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment