New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various ability IDs added #103

Merged
merged 7 commits into from Aug 8, 2018

Conversation

Projects
None yet
2 participants
@Rhazarian
Copy link
Contributor

Rhazarian commented Aug 8, 2018

No description provided.

Rhazarian added some commits Aug 7, 2018

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Aug 8, 2018

Hi, please make sure your fork is clean before commiting further PRs, otherwise your old commits will always be included as it's the case here. The easiest way to achieve this is to make a separate branch for each PR.


The PR itself is good, but you forgot to replace the references to the ids (e.g. ANcl in AbilityObjEditing) inside other packages.
Please update that 🐙

Rhazarian added some commits Aug 8, 2018

@Rhazarian

This comment has been minimized.

Copy link
Contributor Author

Rhazarian commented Aug 8, 2018

Hello.
I added more IDs which were missing & updated them in AbilityObjEditing package.
I'll make clean forks for next PRs, thanks for the advice.

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Aug 8, 2018

Looks good, thanks 👍

Consider starring our main repo https://github.com/wurstscript/WurstScript if you enjoy wurst :)

@Frotty Frotty merged commit 4b97bff into wurstscript:master Aug 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Rhazarian added a commit to Rhazarian/WurstStdlib2 that referenced this pull request Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment