Better inlining in Printing.wurst

[ElusiveMori]

init
    Log.trace("TRACE")
    Log.debug("DEBUG")
    Log.info("INFO")
    Log.warn("WARN")
    Log.error("ERROR")

Produces this code:

function Loglevel_getTag takes integer this returns string
	if this == 0 then
		return "|cffADADADtrace|r"
	elseif this == 1 then
		return "|cff2685DCdebug|r"
	elseif this == 2 then
		return "|cffFFCC00info|r"
	elseif this == 3 then
		return "|cffF47E3Ewarning|r"
	elseif this == 4 then
		return "|cffFB2700error|r"
	endif
	return "?"
endfunction

function printLog takes player showTo, integer loglvl, string msg returns nothing
	if 2 <= loglvl then
		call DisplayTimedTextToPlayer(showTo, 0., 0., 45., Loglevel_getTag(loglvl) + " - " + msg)
	endif
endfunction

function init_Hello takes nothing returns boolean
	call printLog(Player_localPlayer, 0, "TRACE")
	call printLog(Player_localPlayer, 1, "DEBUG")
	call printLog(Player_localPlayer, 2, "INFO")
	call printLog(Player_localPlayer, 3, "WARN")
	call printLog(Player_localPlayer, 4, "ERROR")
	return true
endfunction

Even though the log level is a constant by default, Wurst doesn't know whether to remove the TRACE and DEBUG calls or not, even though the condition inside printLog will never pass.

It also doesn't inline them, which it potentially could.

This PR does some reshuffling so that these printing calls get properly removed when logLevel is constant, and also makes them inline better.

The result of this that the above code now gets compiled into this:

function init_Hello takes nothing returns boolean
	call DisplayTimedTextToPlayer(Player_localPlayer, 0., 0., 45., "|cffFFCC00info|r - INFO")
	call DisplayTimedTextToPlayer(Player_localPlayer, 0., 0., 45., "|cffF47E3Ewarning|r - WARN")
	call DisplayTimedTextToPlayer(Player_localPlayer, 0., 0., 45., "|cffFB2700error|r - ERROR")
	return true
endfunction

[Frotty]

Maybe add to description what the current problem is.
The correct solution might also be just to add/improve optimizations

[Frotty]

Okay, the inlining rules have been improved. The example you posted now gets inlined.
Can you re-check on your project?

[Frotty]

Can reopen if this still persists.