Join GitHub today
Network, Execute fixes & FileIO #26
Overall this is pretty brilliant. I think it's the biggest PR on stdlib. I hope Frotty has a backup of this code in case something happens.
As it stands, the code quaility is very high and I think you've balanced perfection and pragmatism well.
The nature of this stuff is fragile, though. There's necessarily a lot of non-generic type stuff here, bit twiddling, magic values, data reinterpretation, etc. I think that's fine.
My final opinion is that this could go two ways:
I'll let you and Frotty decide which of these variants is the right one. In any case, please someone get a backup, and also thanks again, this is really, really cool
I agree. I think it could be in stdlib to promote easy persistable data.
e: Just as a reminder to @SamuelMoriarty the missing features we talked about;