New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Soundsets class for units soundsets #38

Merged
merged 1 commit into from Jan 11, 2018

Conversation

Projects
None yet
3 participants
@karlek
Copy link
Contributor

karlek commented Jan 10, 2018

I extracted all unit soundsets so we can have static checking of soundsets in wurst 馃尨

Note: I haven't tested all the soundsets

Extraction of names

War3.txt is the text file containing the paths of War3.mpq, and the same with War3xlocal.txt.

The command I ran to extract the names:

$ cat War3.txt War3xlocal.txt | grep '^Units.*\.wav' | awk -F '\\' '{print $(NF-1)}' | sort -u > soundsets

Cheers from
Karlek & Kranx

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Jan 11, 2018

very nice 馃憤 thanks 馃尨
We should probably split up the Assets package into smaller ones and then have the Asset package be one with only public imports of the smaller packages.

@Frotty Frotty merged commit 3d3a5aa into wurstscript:master Jan 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@karlek

This comment has been minimized.

Copy link
Contributor Author

karlek commented Jan 23, 2018

We noticed yesterday that Goblin Alchemist and Tinkerer are missing. I guess that this only concerns the neutral passive heroes that were added through patches. I'll make a new PR to add them. @Frotty can you think of any other units that have been added through patches?

Btw, I can make a PR for your proposal of splitting up the Assets class into separate files. Shall we still call it assets?

@Jampi0n

This comment has been minimized.

Copy link
Contributor

Jampi0n commented Jan 23, 2018

The Firelord was added later as well. You should also check their summons: Clockwork Goblin and Lava Spawn.
Not sure if Volcano or Pocket Factory have sound sets.
I doubt other units are affected, because tavern heroes are basically the only thing you can add in later patches.

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Jan 23, 2018

Pretty much all units from the expansion eh?
I didn't check all names, I suppose you didn't take data from both mpqs?
You can do the asset splitup into an "assets" folder and then have the Asset package be an import public container.

@karlek

This comment has been minimized.

Copy link
Contributor Author

karlek commented Jan 23, 2018

@Jampi0n, thanks I'll look into those.

@Frotty, I did. I guess that my mpq extractor couldn't apply the patch mpq, and therefore it did not find the audio files of the tavern heroes.

Sweet, I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment