New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addAt function in LinkedList class #55

Merged
merged 3 commits into from Mar 10, 2018

Conversation

Projects
None yet
2 participants
@vitalexbel
Copy link
Contributor

vitalexbel commented Mar 10, 2018

Current addAt function is wrong because it creates the new LLEntry, that is connected with the dummy. I fixed it. Now the new LLEntry is correctly connected with the old LLEntry in the place of which it is inserted.
I mean entry.next and entry.prev relations

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Mar 10, 2018

Please add a description to your ticket.
If addAt is incorrect, add a test.

e: Russian comments can also not be accepted. Please make another PR for extra functions you want to add.

@vitalexbel

This comment has been minimized.

Copy link
Contributor

vitalexbel commented Mar 10, 2018

I did not want to add that commit with Russian commentaries.
I wanted to leave it only in my branch
I'll soon redo PR

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Mar 10, 2018

Alright 👍
If you add a Test to LinkedListTests.wurst for addAt I will merge.

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Mar 10, 2018

great 🍭

@Frotty Frotty merged commit 2a6611d into wurstscript:master Mar 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment