New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Upgrade Object Editing #77

Merged
merged 22 commits into from May 17, 2018

Conversation

Projects
None yet
3 participants
@Halithor
Copy link
Contributor

Halithor commented May 15, 2018

This adds support for editing Upgrade objects in wurst! Provides methods for all upgrade effects as useful helpers in the UpgradeDefinition. Exposes the basic methods in the W3QDefinition for people who want to live dangerously.

@@ -0,0 +1,41 @@
package SharedEnums

This comment has been minimized.

@karlek

karlek May 15, 2018

Contributor

Why not name the file Race.wurst?

This comment has been minimized.

@Halithor

Halithor May 15, 2018

Author Contributor

At one point I had more than one Enum in the package (armor type for the set armor defense type effect), but I ended up only sharing race. Perhaps in the future this wouldn't be a bad space for other shared enums to go? Or I can rename it to Race.

This comment has been minimized.

@Frotty

Frotty May 15, 2018

Member

It would be good to have shared/common objediting stuff in one packge, but the name "SharedEnums" isn't good imo.

Caster

public enum UpgradeEffectType
NONE

This comment has been minimized.

@Frotty

Frotty May 15, 2018

Member

afaik the convention is all uppercase and underscore since these are basically constants.
In any case I wouldn't mix the two.

@Frotty Frotty referenced this pull request May 15, 2018

Closed

Complete UpgradeObjEditing #32

Halithor added some commits May 15, 2018

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented May 17, 2018

Amazing ❤️

@Frotty Frotty merged commit 3e8a536 into wurstscript:master May 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Halithor Halithor deleted the Halithor:UpgradeObjectEditing branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment