New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new TimerDialog package #90

Merged
merged 3 commits into from Jul 12, 2018

Conversation

Projects
None yet
3 participants
@Overkane
Copy link
Contributor

Overkane commented Jul 12, 2018

Wrappers for Timer Dialog API from common.j and small fixes in Angle package

new TimerDialog package
Wrappers for Timer Dialog API from common.j and small fixes in Angle package
public function timerdialog.setTitle(string title)
TimerDialogSetTitle(this, title)

public function timerdialog.setTitleColor(int red, int green, int blue, int alpha)

This comment has been minimized.

@Frotty

Frotty Jul 12, 2018

Member

please add an overloaded version of this function taking a colorA tuple.

This comment has been minimized.

@Overkane

Overkane Jul 12, 2018

Author Contributor

Done

new TimerDialog package v2
Overloaded functions with colorA tuple
@Frotty

Frotty approved these changes Jul 12, 2018

public function timerdialog.setTimeColor(colorA colorA)
TimerDialogSetTimeColor(this, colorA.red, colorA.green, colorA.blue, colorA.alpha)

public function timerdialog.setSpeed(real speedMultFactor)

This comment has been minimized.

@Cokemonkey11

Cokemonkey11 Jul 12, 2018

Contributor

Can you add a doc comment for what this is for? I'm not familiar with the native


/** get the sinus of this angle */

This comment has been minimized.

@Cokemonkey11

Cokemonkey11 Jul 12, 2018

Contributor

/sinus/sine/

@Cokemonkey11

This comment has been minimized.

Copy link
Contributor

Cokemonkey11 commented Jul 12, 2018

LGTM

@Frotty Frotty merged commit 99429ee into wurstscript:master Jul 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Jul 12, 2018

Nice 🍬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment