New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage type fixes #97

Merged
merged 5 commits into from Jul 30, 2018

Conversation

Projects
None yet
3 participants
@Trokkin
Copy link
Contributor

Trokkin commented Jul 28, 2018

Moved from DamageModify PR.

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Jul 29, 2018

And again, why are all these commits about group stuff in here???
The title is "Damage type fixes".

@Trokkin

This comment has been minimized.

Copy link
Contributor Author

Trokkin commented Jul 29, 2018

You want me to make a PR dependent on another PR dependent on another one?
Yes, my fault, I can't embrace the idea of PR being as small as one little commit when it is a part of some bigger change.

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Jul 30, 2018

The group stuff doesn't fix anything. it's a nice addition, but yeah, doesn't really need to be same PR.
Anyway, looks good, thanks a lot 🍆

@Frotty Frotty merged commit e58c306 into wurstscript:master Jul 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Cokemonkey11

This comment has been minimized.

Copy link
Contributor

Cokemonkey11 commented Jul 30, 2018

I can't embrace the idea of PR being as small as one little commit when it is a part of some bigger change.

With some practice the work needed to manage your git dependency tree becomes less and more natural

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment