New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitId asset list, categorized by race and campaign #98

Merged
merged 5 commits into from Aug 3, 2018

Conversation

Projects
None yet
3 participants
@Trokkin
Copy link
Contributor

Trokkin commented Jul 28, 2018

All data is taken from unitUI.slk
Model and scale data is provided in comments to help recognize some units.

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Jul 29, 2018

why for version 1.26a?
Looks neat, only thing which I already mentioned last time is that the names can become a bit long.
6 char-id 'ncap' vs UnitIds_NightElfCampaign.corruptedAncientProtector might be a bit annoying.
Might be fine though

static constant scoutTower = 'hwtw'
static constant gryphonAviary = 'hgra'
static constant castle = 'hcas'
static constant humanBarracks = 'hbar'

This comment has been minimized.

@Cokemonkey11

Cokemonkey11 Jul 29, 2018

Contributor

maybe just Barracks since inside UnitIds_Human namespace?

static constant humanBarracks = 'hbar'
static constant keep = 'hkee'
static constant blacksmith = 'hbla'
static constant humanLumberMill = 'hlum'

This comment has been minimized.

@Cokemonkey11

Cokemonkey11 Jul 29, 2018

Contributor

Just lumberMill maybe

static constant heroArchMage = 'Hamg'
static constant heroMountainKing = 'Hmkg'
static constant heroPaladin = 'Hpal'
static constant bloodElfSorceror = 'Hblm'

This comment has been minimized.

@Cokemonkey11

Cokemonkey11 Jul 29, 2018

Contributor

heroBloodMage?

static constant waterElemental2 = 'hwt2'
static constant waterElemental3 = 'hwt3'
static constant militia = 'hmil'
static constant rocketTank = 'hrtt'

This comment has been minimized.

@Cokemonkey11

This comment has been minimized.

@Trokkin

Trokkin Jul 29, 2018

Author Contributor

Maybe steamTankRocket

@Frotty Frotty changed the title UnitId asset list, categorized by race and campaing UnitId asset list, categorized by race and campaign Jul 31, 2018

Trokkin added some commits Jul 31, 2018

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Aug 1, 2018

Not too sure about the scale comments etc. ? Will people really look into that?

I think 1 big group is better, but now the entries are not alphabetically ordered anymore, please restore that.

@Trokkin

This comment has been minimized.

Copy link
Contributor Author

Trokkin commented Aug 1, 2018

As far as I used to, custom units should inherit properties of their model, like backswing point, shadow or missile firing point, thus the model is the key parameter when choosing base unit. Selection scale is also important and should correlate with the model scale and the model itself, so I focus on these too in hope that selection scale would be changed corresponding to scale change because I'm kinda tired of seeing inproper settings for units.

They never was alphabetically ordered, you know. At least for english: original data I was working with first was from 1.26a russian client, extracted by War3ObjectEditor which never worked with new versions, and there was alphabetical sort within categories.

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Aug 3, 2018

🍬 Thanks

@Frotty Frotty merged commit db340b5 into wurstscript:master Aug 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment