Bugfix: make decoding_palette and transparent_color variables that get passed along instead of instance variables. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wvanbergen
force-pushed
the
transparency_cleanup
branch
from
9d62baf
to
126cb45
Compare
…e passed along while decoding instead of instance variables.
wvanbergen
force-pushed
the
transparency_cleanup
branch
from
126cb45
to
c1d61cd
Compare
|
@lencioni any chance you can look at this to see if it makes sense? |
|
This makes sense to me and I like the more functional approach. However, these aren't instance variables, they are local variables, so you might want to update your commit message. |
wvanbergen
changed the title
wvanbergen
added a commit
to wvanbergen/oily_png
that referenced
this issue
Sep 13, 2016
…an instance variable on the decoding module. This fixes some issues around transparency, which were fixed in ChunkyPNG before: wvanbergen/chunky_png#112
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this issue
Oct 15, 2016
* Update PNG decoding to use palette that is passed around, instead of an instance variable on the decoding module. This fixes some issues around transparency, which were fixed in ChunkyPNG before: wvanbergen/chunky_png#112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Make
decoding_paletteandtransparent_colorinstance variables of the canvas instead of of the Canvas class.Should fix #58. Thanks to @jhamon for finding the cause of this.