Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Group Rails3 RoutingErrors with HTTP method #131

Merged
merged 1 commit into from

2 participants

@asanghi

I realized that it would be better to group the 404 with the method type too. So a GET /missing and a POST /missing are reported separately.

Shouldve sent this with the earlier post but didnt understand the usage unti now.

@barttenbrinke barttenbrinke merged commit 1f2f22d into wvanbergen:master
@asanghi

Thanks heaps!

Release Plans?

@asanghi asanghi deleted the asanghi:add_routing_errors branch
@barttenbrinke
Collaborator

Released 1.12.8 ... thank you again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 22, 2013
  1. @asanghi
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  lib/request_log_analyzer/file_format/rails3.rb
View
3  lib/request_log_analyzer/file_format/rails3.rb
@@ -103,7 +103,8 @@ class Rails3 < Base
analyze.frequency :category => REQUEST_CATEGORIZER, :title => 'Process blockers (> 1 sec duration)',
:if => lambda { |request| request[:duration] && request[:duration] > 1.0 }
- analyze.frequency :missing_resource, :title => "Routing Errors"
+ analyze.frequency :category => lambda{|x| "[#{x[:missing_resource_method]}] #{x[:missing_resource]}"},
+ :title => "Routing Errors", :if => lambda{ |request| !request[:missing_resource].nil? }
end
class Request < RequestLogAnalyzer::Request
Something went wrong with that request. Please try again.