In combination with ordering and will_paginate the sql is broken on postgresql

[iNecas]

Example call:

ConfigTemplate.order('name').search_for("name ~ Kickstart Default and kind = PXELinux", {:order=>nil}).paginate({:page=>1})

Produces:

ActiveRecord::StatementInvalid: PGError: ERROR:  syntax error at or near "FIRST"

LINE 1: ...fig_templates".id, "config_templates"."name"NULLS FIRST  AS ...

 SELECT  DISTINCT "config_templates".id, "config_templates"."name"NULLS FIRST  A
S alias_0 FROM "config_templates" LEFT OUTER JOIN "taxable_taxonomies" ON "taxab
le_taxonomies"."taxable_id" = "config_templates"."id" AND "taxable_taxonomies"."
taxable_type" 

[abenari]

I am failing to reproduce the error.
Please add more information on the environment

[iNecas]

Running this against latest develop branch of Foreman on Postre fails for me:

curl -u admin:changeme -k 'http://localhost:3000/api/config_templates?search=name+%7E+Kickstart+Default+and+kind+%3D+PXELinux'

[ohadlevy]

@iNecas does this happens on rails 3.2.13 as well?

[brocktimus]

I use will_paginate with ordering and scoped search frequently. I think the difference is I never use the order hash in the search_for method. The below works.

Model.where(hash).order(:somefield).page(params[:page]).search_for('some things')

Is there some reason we offer an order clause? It seems like it might have been useful in 2.3 but seems quite redundant now.

[wvanbergen]

Scoped search has a default ordering, and you can override it in the query by using the options parameter.
It was added by @abenari in 2011: https://github.com/wvanbergen/scoped_search/tree/f17e94483504bed6f27b025d831f28adb0a945eb

It seems related to the auto completer but I am not quite sure.

[abenari]

The SQL error above seems to be rails 3.2.8 to 3.2.12 PostgreSQL adapter related and not a scoped_search issue.
I am trying to isolate the problem.

The order functionality in scoped_search was meant to be used with the sorting helpers in:
https://github.com/wvanbergen/scoped_search/blob/master/lib/scoped_search/rails_helper.rb#L15
It is probably redundant now.

[abenari]

I have managed to reproduce the error with PG and rails 3.2.8 it is gone in rails 3.2.9.
closing this issue as it is not a scoped_search issue.