Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update finagle-core, finagle-http, ... to 20.4.0 #1024

Merged
merged 1 commit into from Apr 2, 2020

Conversation

scala-steward
Copy link
Contributor

Updates

from 20.3.0 to 20.4.0.
Changelog

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.twitter" } ]

labels: library-update, semver-minor

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #1024 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1024   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files         268      268           
  Lines       10108    10108           
  Branches      686      686           
=======================================
  Hits         8306     8306           
  Misses       1802     1802           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc6d9d...563568e. Read the comment docs.

@xerial xerial merged commit fc850c2 into wvlet:master Apr 2, 2020
@xerial
Copy link
Member

xerial commented Apr 2, 2020

It has a bug fix for headerMap. We need to merge this.

@@ -35,7 +35,7 @@ New Features:
- airframe-http: Support Scala.js for defining Web interfaces as well as Scala JVM [[0e017db](https://github.com/wvlet/airframe/commit/0e017db)]
- airframe-http: Support adding a custom codec to clients ([#1004](https://github.com/wvlet/airframe/issues/1004)) [[9675669](https://github.com/wvlet/airframe/commit/9675669)]
- airframe-http: Add cross-platform HttpMessage.Request and Response classes ([#982](https://github.com/wvlet/airframe/issues/982)) [[f55d438](https://github.com/wvlet/airframe/commit/f55d438)]
- airframe-http-finagle: Update finagle-core, finagle-http, ... to 20.3.0 ([#965](https://github.com/wvlet/airframe/issues/965)) [[111e5ad](https://github.com/wvlet/airframe/commit/111e5ad)]
- airframe-http-finagle: Update finagle-core, finagle-http, ... to 20.4.0 ([#965](https://github.com/wvlet/airframe/issues/965)) [[111e5ad](https://github.com/wvlet/airframe/commit/111e5ad)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must not update the past release notes. This line must be reverted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know scala-steward changes such release notes too. I'll be more careful next time 😓

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was really surprised that scala-steward can change this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants