Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-codec: #1093 Add MessageCodec.fromString(String) #1095

Merged
merged 1 commit into from May 18, 2020

Conversation

xerial
Copy link
Member

@xerial xerial commented May 17, 2020

Closes #1093

@xerial xerial requested a review from shimamoto May 17, 2020 21:50
@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #1095 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files         270      270           
  Lines       10292    10298    +6     
  Branches      670      698   +28     
=======================================
+ Hits         8487     8492    +5     
- Misses       1805     1806    +1     
Impacted Files Coverage Δ
...main/scala/wvlet/airframe/codec/MessageCodec.scala 85.45% <100.00%> (+0.26%) ⬆️
...cala/wvlet/airframe/http/HttpClientException.scala 75.75% <0.00%> (-1.30%) ⬇️
...c/main/scala/wvlet/airframe/control/Parallel.scala 94.23% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b77ad5...2ea19e2. Read the comment docs.

Copy link
Collaborator

@shimamoto shimamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@xerial xerial merged commit 5cbdcc1 into wvlet:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airframe-codec: MessageCodec[X].fromString(s:String): X
2 participants