Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-di: #651 Support design-time lifecycle hooks #655

Merged
merged 8 commits into from Sep 3, 2019

Conversation

xerial
Copy link
Member

@xerial xerial commented Sep 2, 2019

Resolves #651

@xerial xerial changed the title [WIP] #651 Design time lifecycle hooks airframe-di: #651 Design time lifecycle hooks Sep 2, 2019
@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #655 into master will decrease coverage by 0.05%.
The diff coverage is 90.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
- Coverage    82.1%   82.04%   -0.06%     
==========================================
  Files         240      240              
  Lines        8836     8880      +44     
  Branches      696      678      -18     
==========================================
+ Hits         7255     7286      +31     
- Misses       1581     1594      +13
Impacted Files Coverage Δ
...rframe/src/main/scala/wvlet/airframe/package.scala 91.66% <ø> (ø) ⬆️
...irframe/src/main/scala/wvlet/airframe/Binder.scala 74.28% <100%> (+4.28%) ⬆️
...c/main/scala/wvlet/airframe/LifeCycleManager.scala 95.28% <100%> (+0.23%) ⬆️
...irframe/src/main/scala/wvlet/airframe/Design.scala 92.85% <84.84%> (-5.33%) ⬇️
...rc/main/scala/wvlet/airframe/AirframeSession.scala 92.92% <92.85%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46eb9a1...eb10b71. Read the comment docs.

@xerial xerial changed the title airframe-di: #651 Design time lifecycle hooks airframe-di: #651 Support design-time lifecycle hooks Sep 3, 2019
@xerial xerial requested a review from takezoe September 3, 2019 00:05
@xerial xerial merged commit de526a5 into wvlet:master Sep 3, 2019
@xerial xerial deleted the design-time-lifecycle-hooks branch September 3, 2019 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airframe-di: design-time lifecycle hooks
1 participant