Skip to content

Conversation

@Tyler-Keith-Thompson
Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson commented Jan 14, 2022

Linked Issue:

Checklist:

Tyler-Keith-Thompson and others added 2 commits January 14, 2022 12:30
…riber to WorkflowDecodable because it is even exhausting typing that out in a commit message to say we removed it - TT RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…ll gonna play games while Morgan fixes the problem - TT RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
@Tyler-Keith-Thompson Tyler-Keith-Thompson requested a review from a team as a code owner January 14, 2022 22:00
Tyler-Keith-Thompson and others added 2 commits January 14, 2022 15:18
…rsion stops a test from failing for the right reasons - TT
… from JSON along with helpful errors - TT RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (data-driven@cca34ea). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             data-driven     #161   +/-   ##
==============================================
  Coverage               ?   91.21%           
==============================================
  Files                  ?       98           
  Lines                  ?     2446           
  Branches               ?        0           
==============================================
  Hits                   ?     2231           
  Misses                 ?      215           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca34ea...2f2d1ef. Read the comment docs.

Tyler-Keith-Thompson and others added 4 commits January 14, 2022 16:53
…al test for subclasses - TT RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…pport creating typed workflows from SwiftUI views has been removed, now you can only create them through data - TT RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…the entire workflow should just be as simple as adding additional fields around it. The trick was to make something that can be decoded easily, that has been done - TT
@Tyler-Keith-Thompson Tyler-Keith-Thompson marked this pull request as draft January 18, 2022 17:47
…nce conversation decided that was not an important feature. Added new failing tests so the todos cannot be skipped - TT RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
Tyler-Keith-Thompson and others added 2 commits January 18, 2022 11:48
… to be internal, fixed a file_types_order issue - TT RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…antic side - TT RAG

Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
@Tyler-Keith-Thompson Tyler-Keith-Thompson marked this pull request as ready for review January 18, 2022 19:06
@Tyler-Keith-Thompson Tyler-Keith-Thompson added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 18, 2022
@morganzellers morganzellers merged commit 16456e3 into data-driven Jan 24, 2022
@morganzellers morganzellers deleted the data-drive-json-consumption branch January 24, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants