Data driven json launch persistence styles #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riber to WorkflowDecodable because it is even exhausting typing that out in a commit message to say we removed it - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…ll gonna play games while Morgan fixes the problem - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…rsion stops a test from failing for the right reasons - TT
… from JSON along with helpful errors - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…al test for subclasses - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…pport creating typed workflows from SwiftUI views has been removed, now you can only create them through data - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…the entire workflow should just be as simple as adding additional fields around it. The trick was to make something that can be decoded easily, that has been done - TT
…nce conversation decided that was not an important feature. Added new failing tests so the todos cannot be skipped - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
… to be internal, fixed a file_types_order issue - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…antic side - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…or launch styles and created some scaffolding for decoding them - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…he new factory with parameters - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…unch styles correctly - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…decoded reasonably for UIKit - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…. if only we were done - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…ocs - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…ings - TT RAG Co-authored-by: Richard Gist <Richard.Gist@wwt.com>
…st to make sure flowPersistence was passed through to ExtendedFlowRepresentableMetadata - TT
…nting issues - TT
Codecov Report
@@ Coverage Diff @@
## data-driven #163 +/- ##
==============================================
Coverage ? 91.23%
==============================================
Files ? 100
Lines ? 2488
Branches ? 0
==============================================
Hits ? 2270
Misses ? 218
Partials ? 0 Continue to review full report at Codecov.
|
Richard-Gist
added
enhancement
morganzellers
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue:
Checklist: