Skip to content

Adds ability to codegen a type registry to the CLI #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MattFreiburgAsynchrony merged 7 commits into from
Mar 29, 2022
Merged

Adds ability to codegen a type registry to the CLI #199

MattFreiburgAsynchrony merged 7 commits into from
Mar 29, 2022

Conversation

@Tyler-Keith-Thompson
Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson commented Mar 29, 2022 •
edited
Loading

Linked Issue:

Checklist:

Tyler-Keith-Thompson and others added 6 commits March 28, 2022 13:15
@Tyler-Keith-Thompson
[data-driven-codegen] - Decided to go with a different approach, ther…
7ea842c 
…e is now one SwiftCurrent CLI and generating IR is part of what it does - TT
@Tyler-Keith-Thompson @MattFreiburgAsynchrony
[skip ci] data-driven-codegen - First test of codegen done, codegen i…
45ddba9 
…s currently hard-coded and inaccurate - TT MF

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>
@Tyler-Keith-Thompson @MattFreiburgAsynchrony
[data-driven-codegen] - Extracted common logic between CLI commands a…
d82b993 
…nd codegen now produces correct types in registry for all known edge cases - TT MF

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>
@Tyler-Keith-Thompson @MattFreiburgAsynchrony
[data-driven-codegen] - Convenience methods added to codegen - TT MF
38bb559 
Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>
@Tyler-Keith-Thompson @MattFreiburgAsynchrony
[data-driven-codegen] - Discovered a bug but added the ability to out…
cac47df 
…put to a specific file - TT MF

Co-authored-by: Matt Freiburg <Matt.Freiburg@wwt.com>
@Tyler-Keith-Thompson
[data-driven-codegen] - Fixed bug when CLI was pointed directly at a …
e1427ba 
…file, not a directory - TT
@Tyler-Keith-Thompson Tyler-Keith-Thompson requested a review from a team as a code owner March 29, 2022 18:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #199 (a8cea6e) into data-driven (eda8ecb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           data-driven     #199   +/-   ##
============================================
  Coverage        90.62%   90.62%           
============================================
  Files              110      110           
  Lines             2719     2719           
============================================
  Hits              2464     2464           
  Misses             255      255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda8ecb...a8cea6e. Read the comment docs.

@MattFreiburgAsynchrony MattFreiburgAsynchrony merged commit 09a2c68 into data-driven Mar 29, 2022
@MattFreiburgAsynchrony MattFreiburgAsynchrony deleted the data-driven-codegen branch March 29, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MattFreiburgAsynchrony MattFreiburgAsynchrony MattFreiburgAsynchrony approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tyler-Keith-Thompson @codecov-commenter @MattFreiburgAsynchrony