New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive verbosity in .fpb files, causing needless inflation in repository size. #467

Open
specing opened this Issue Aug 27, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@specing

specing commented Aug 27, 2018

For example this line: <event name="OnTextEnter"></event> .. why include it if there is no event attached? Since a reasonable default is for there to be no handler, exclude such events from the XML.

The same also applies to other xml tags/components/items/whatever.

PS: can you stop with the excessive merge commits? They are cluttering your project's git history and making it difficult to see what the actual changes were. Use git am or something similar, git on its own already distinguishes between author and commiter in every commit.

@jhasse

This comment has been minimized.

Show comment
Hide comment
@jhasse

jhasse Aug 27, 2018

Member

making it difficult to see what the actual changes were.

Why? You can still see the commits of the branch that was merged.

Member

jhasse commented Aug 27, 2018

making it difficult to see what the actual changes were.

Why? You can still see the commits of the branch that was merged.

@specing

This comment has been minimized.

Show comment
Hide comment
@specing

specing Aug 27, 2018

I can, but the noise to signal ratio is 21% in recent history, which is way too high. I'd show you an image of what I'm seeing, but since BadHub supports neither .jpg nor .png I'm running out of options.

specing commented Aug 27, 2018

I can, but the noise to signal ratio is 21% in recent history, which is way too high. I'd show you an image of what I'm seeing, but since BadHub supports neither .jpg nor .png I'm running out of options.

@specing

This comment has been minimized.

Show comment
Hide comment
@specing

specing Aug 27, 2018

mergespam

Ok, looks like more javascript had to be enabled.

specing commented Aug 27, 2018

mergespam

Ok, looks like more javascript had to be enabled.

@acolomb

This comment has been minimized.

Show comment
Hide comment
@acolomb

acolomb Aug 27, 2018

Contributor

@specing, still off topic: Git can skip merge commits when printing history. Just add the --no-merges option. I do like the merge commits in the history because they record links to relevant discussion, which is equally important as the code history.

Contributor

acolomb commented Aug 27, 2018

@specing, still off topic: Git can skip merge commits when printing history. Just add the --no-merges option. I do like the merge commits in the history because they record links to relevant discussion, which is equally important as the code history.

@specing

This comment has been minimized.

Show comment
Hide comment
@specing

specing Aug 28, 2018

29 elements on a wxDialog results in a 143 KiB .fbp. This is unacceptable and any reasonable dev would kill me if I tried to commit it to repo! That would be >15MB just for formbuilder files if I moved all GUI code to it. And most of those project file would be 95% defaults.

specing commented Aug 28, 2018

29 elements on a wxDialog results in a 143 KiB .fbp. This is unacceptable and any reasonable dev would kill me if I tried to commit it to repo! That would be >15MB just for formbuilder files if I moved all GUI code to it. And most of those project file would be 95% defaults.

@jhasse

This comment has been minimized.

Show comment
Hide comment
@jhasse

jhasse Aug 28, 2018

Member

Those 143 kb will be a lot less compressed though, so you can't compare it with most binary files.

Still: We get the point and this is a valid issue.

Member

jhasse commented Aug 28, 2018

Those 143 kb will be a lot less compressed though, so you can't compare it with most binary files.

Still: We get the point and this is a valid issue.

@jhasse jhasse added the enhancement label Aug 31, 2018

@jhasse jhasse added this to the 3.9.0 milestone Aug 31, 2018

jhasse added a commit that referenced this issue Sep 28, 2018

@jhasse

This comment has been minimized.

Show comment
Hide comment
@jhasse

jhasse Sep 28, 2018

Member

Skipping empty events was relatively easy and doesn't seem to break anything.

The same isn't true for properties though. Empty properties aren't the default values and Property::IsDefaultValue also doesn't the tell the whole truth, as the default values aren't always the ones from PropertyInfo. I'll take a close look, it's really hard without any (unit) tests though ...

Member

jhasse commented Sep 28, 2018

Skipping empty events was relatively easy and doesn't seem to break anything.

The same isn't true for properties though. Empty properties aren't the default values and Property::IsDefaultValue also doesn't the tell the whole truth, as the default values aren't always the ones from PropertyInfo. I'll take a close look, it's really hard without any (unit) tests though ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment