Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't compile against latest wx source. Undefined symbol wxPG_PROP_NO_ESCAPE. Fix included. #544

Closed
jmoraleda opened this issue Sep 21, 2019 · 1 comment

Comments

@jmoraleda
Copy link

commented Sep 21, 2019

Symbol wxPG_PROP_NO_ESCAPE is no longer used by wx and is no longer defined. (See wx commit wxWidgets/wxWidgets@37f9c6f where wxLongStringProperty and other classes were refactored).

Thus current code compilation fails with:

[1/3] Compiling C++ object 'wxformbuilder@exe/src_rad_inspector_objinspect.cpp.o'.
FAILED: wxformbuilder@exe/src_rad_inspector_objinspect.cpp.o 
c++ -Iwxformbuilder@exe -I. -I.. -I../sdk/plugin_interface -Isubprojects/ticpp -I../subprojects/ticpp -I/usr/local/lib/wx/include/gtk3-unicode-3.1 -I/usr/local/include/wx-3.1 -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++17 -g -Wall -Wextra -Winit-self -Wimplicit-fallthrough -Wpedantic -Wdelete-non-virtual-dtor -Wlogical-op -Wduplicated-cond -Wduplicated-branches -Wno-overloaded-virtual -Wtautological-compare -Wextra-semi -Wno-ignored-qualifiers -Wno-unused-parameter -Wno-cast-function-type -D__WXFB_DEBUG__ -DUSE_MEDIACTRL -pthread -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__  -MD -MQ 'wxformbuilder@exe/src_rad_inspector_objinspect.cpp.o' -MF 'wxformbuilder@exe/src_rad_inspector_objinspect.cpp.o.d' -o 'wxformbuilder@exe/src_rad_inspector_objinspect.cpp.o' -c ../src/rad/inspector/objinspect.cpp
../src/rad/inspector/objinspect.cpp: In member function ‘wxPGProperty* ObjectInspector::GetProperty(PProperty)’:
../src/rad/inspector/objinspect.cpp:254:23: error: ‘wxPG_PROP_NO_ESCAPE’ was not declared in this scope
   result->ChangeFlag( wxPG_PROP_NO_ESCAPE, true );
                       ^~~~~~~~~~~~~~~~~~~
../src/rad/inspector/objinspect.cpp:254:23: note: suggested alternative: ‘wxPG_PROP_NOEDITOR’
   result->ChangeFlag( wxPG_PROP_NO_ESCAPE, true );
                       ^~~~~~~~~~~~~~~~~~~
                       wxPG_PROP_NOEDITOR
ninja: build stopped: subcommand failed.

The solution is simple: Remove the offending line 254 of src/rad/inspector/objinspect.cpp since it is no longer needed. For clarity: This is the offending line that should be removed as it is no longer necessary:

		result->ChangeFlag( wxPG_PROP_NO_ESCAPE, true );
@sodevel

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

Thanks for the notice, i already discovered this by myself some time ago, but wxWidgets also broke something else that actually made it impossible to enter newlines into wxLongStringProperties. This got fixed only recently, but i still need to investigate if the removal of this flag has any bad effects on wxWidgets 3.0.4 which is currently used for (some) of the CI builds.

jmoraleda added a commit to jmoraleda/wxFormBuilder that referenced this issue Oct 3, 2019
jmoraleda added a commit to jmoraleda/wxFormBuilder that referenced this issue Oct 3, 2019
@sodevel sodevel closed this in fb44d9a Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.