Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Component to wxWidgets Library list #193

Open
mtangoo opened this issue Nov 1, 2021 · 8 comments
Open

Add Component to wxWidgets Library list #193

mtangoo opened this issue Nov 1, 2021 · 8 comments

Comments

@mtangoo
Copy link

mtangoo commented Nov 1, 2021

The wxWidgets Community intends to track list of maintained wx Libraries.
I would like to invite you comment on whether you think your component should be included or not.
See: https://forums.wxwidgets.org/viewtopic.php?p=208956

Thanks,
Stef, fellow wxWidgetter!

@xleclercq
Copy link
Member

Hi there. Thanks for the interest. It is true that I haven't been able to spend as much time as I'd like on this. At the moment I would consider the library to be in a state where it is a good starting point for one's own projects but would require modifications to be production ready. So forking is still pretty much what I'd recommend for anyone wishing to use it.

So looking at the criteria for the list:

  • high quality, ready for production or close to it
  • support some kind of build system (CMake etc.)
  • support at least two of the three major platforms (Windows, Linus, OSX)
  • are actively maintained

I'd say it fails point 1 and 4. I kind of hope that will change in the near future and the more interest there is the more it motivates me to spend some time on it definitely. So I'll keep this list in mind and try to get closer to meet the criteria.

@mtangoo
Copy link
Author

mtangoo commented Nov 2, 2021

Great to hear your comments. Will definitely keep eye on this ticket. Please consider updating it when you can!

@asmwarrior
Copy link

I make a codeblocks cbp project file for building your library under codeblocks+msys2.
See: https://github.com/asmwarrior/wxCharts

The static library builds OK, and I have create cbp for two samples.

But I have forked from: https://github.com/playgithub/wxCharts
I see that playgithub has changed the header file folder names.

@xleclercq
Copy link
Member

I don't know why playgithub have changed the location of the header files. From the commits it seems they added CMake makefiles and Conan support. I will add it to my list of things to look at.

I choose the header path to be similar to how someone would include other wxWidgets header but maybe "wx" should be reserved for the official wxWidgets code? I'll need to check what other 3rd party libs are doing.

@asmwarrior
Copy link

About the file name structure, I think your original folder is the way we should go.

I just looked at the 3rd libraries listed in this page: Moderated list of useful wxWidgets extensions

Their header name are like: include/wx/xxxx.h.

@mtangoo
Copy link
Author

mtangoo commented Dec 9, 2021

I choose the header path to be similar to how someone would include other wxWidgets header but maybe "wx" should be reserved for the official wxWidgets code? I'll need to check what other 3rd party libs are doing.

I suggest filename change rather than folder structure. Was looking at file, dunno why every file have wxfilename.h or wxfilename.cpp

hving to include just wx/filename sounds great to me than wx/wxfilename.h

@xleclercq
Copy link
Member

I choose the header path to be similar to how someone would include other wxWidgets header but maybe "wx" should be reserved for the official wxWidgets code? I'll need to check what other 3rd party libs are doing.

I suggest filename change rather than folder structure. Was looking at file, dunno why every file have wxfilename.h or wxfilename.cpp

hving to include just wx/filename sounds great to me than wx/wxfilename.h

Looking at the wxWidgets code itself it's indeed closer to "wx/filename.h". I will migrate to that convention however it's like to be done over time and not in one go.

@asmwarrior
Copy link

I just noticed that playgithub's work in the forke https://github.com/playgithub/wxCharts work has merged, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants