Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option in `build.py` to select components #1138

Closed
cykerway opened this issue Jan 12, 2019 · 10 comments

Comments

Projects
None yet
3 participants
@cykerway
Copy link
Contributor

commented Jan 12, 2019

While this is very easy to run:

python build.py dox etg --nodoc sip build

Can we add some option to selectively enable/disable some components?

I'm trying to build for gtk2 on Fedora 29 but there is not webkitgtk any more because it was removed in Fedora 27. (Maybe this is why you disabled gtk2 builds after Fedora 26?)

But currently I don't need webview. In fact I don't have libwebkitgtk-1.0.so on my system. But this shouldn't have an effect on other parts of wxWidgets and wxPython. wxWidgets has an --enable-webview option, and it automatically disables webview if configure script detects webkitgtk is not available. So build_wx seems to be working. But I don't see how I can tell build_py to ignore webview. Does it sound good if I just comment some lines in wscript? Any chance we can get an option in build.py for doing that? Thank you.

@swt2c

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2019

So, in 4.0.4, there should be stubs automatically generated if wxPython doesn't detect that webview support is built into wxWidgets. wx.WebView will exist in wxPython, but if you try to instantiate it, it will fail. Have you tried 4.0.4?

@cykerway

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2019

I'm using 4.0.4. What I get is a link failure. wxWidgets is compiled with --enable-webview (per default). I don't have webkitgtk, and there is a warning detecting this when configuring wxWidgets. I'm not sure if the wxPython stubs would see this as support is built into wxWidgets. The compilation fails so I don't have a chance to try.

@swt2c

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2019

Are you actually passing --enable-webview?

@cykerway

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2019

No, I didn't have it on my command line. But the configure script said it didn't find webkitgtk and disabled webview. My command line is pretty much the same as in README, except with gtk2.

@swt2c

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2019

Okay, you are right, even with the stubs, wxPython will still try to link with the the webview library unconditionally.

@cykerway

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

Thanks for confirmation. This is what I'm doing on wscript. I haven't experienced anything weird with the build result. If you can confirm this is actually a reasonable way of doing so, that would be great. Fixing the stubs, or having a modular build option in build.py would be even better.

@swt2c

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

Yeah, that's fine for a quick hack for disabling WebView.

Just out of curiosity, why are you wanting/needing to use GTK2?

@cykerway

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

Ah, I'm old-fashioned old guy?

@swt2c

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

OK, just checking whether you were running into particular bugs with the GTK3 version. You will probably have to move on eventually though. :-) Even Debian is talking about getting rid of GTK2 in its next version (after Buster).

@RobinD42

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Calling this fixed after #1208 and also the ability to generate stubs for missing items.

@RobinD42 RobinD42 closed this Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.