New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stock labels don't conform to Windows Design Guidelines #787

Closed
dhowland opened this Issue Mar 15, 2018 · 5 comments

Comments

Projects
3 participants
@dhowland

dhowland commented Mar 15, 2018

Operating system: Windows 10
wxPython version: 4.0.1
Stock or custom build: Stock
Python version: 3.6
Stock or custom build: Stock

Description of the problem:

A menu item or button that opens a dialog for more information is supposed to end with "..." according to Microsoft.

Using wx.ID_OPEN produces "Open..." but using wx.ID_SAVEAS produces "Save as" which is incorrect.

See the bottom of this page for guidelines.

Note that the docs are actually correct on the "Stock Items" page, but the generated label is not.

@dhowland

This comment has been minimized.

dhowland commented Mar 15, 2018

This appears to be a bug in wxWidgets in src/common/stockitem.cpp.

I don't have a login to the wxWidgets trac system, so I'll leave this here.

@mesalu mesalu added the wxWidgets label Mar 15, 2018

@dhowland

This comment has been minimized.

dhowland commented Mar 16, 2018

Pull request has been issued to wxWidgets: wxWidgets/wxWidgets#763

@RobinD42

This comment has been minimized.

Member

RobinD42 commented Mar 16, 2018

Pull request has been issued to wxWidgets

Thanks. You may want to ask that it be merged into the 3.0 branch too.

@RobinD42 RobinD42 added this to To do in 4.0.2 May 15, 2018

@RobinD42

This comment has been minimized.

Member

RobinD42 commented Jun 5, 2018

I've cherry-picked the change into the WX_3_0_BRANCH and will update our submodule link.

RobinD42 added a commit to RobinD42/Phoenix that referenced this issue Jun 5, 2018

@RobinD42 RobinD42 moved this from To do to In progress in 4.0.2 Jun 5, 2018

RobinD42 added a commit that referenced this issue Jun 5, 2018

Merge pull request #879 from RobinD42/fix-issue787
Update submodule link for #787

RobinD42 added a commit that referenced this issue Jun 5, 2018

Add changelog for #787
(cherry picked from commit c1fdde7)
@RobinD42

This comment has been minimized.

Member

RobinD42 commented Jun 5, 2018

Fixed by #879

@RobinD42 RobinD42 closed this Jun 5, 2018

4.0.2 automation moved this from In progress to Done Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment