New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awg.aui.AuiManager may reset the automatic notebook pages order #882

Closed
tianzhuqiao opened this Issue Jun 13, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@tianzhuqiao

tianzhuqiao commented Jun 13, 2018

awg.aui.AuiManager may reset the automatic notebook page order

  1. run agw/aui.py
  2. drag the the page in an automatic notebook to change its order
  3. drag any pane to change its size (to trigger AuiManager.Update())
  4. the order of automatic notebook pages will be reset

It looks like it is due to

  1. in UpdateNotebook() (~ line 6669), if an automatic notebook has more than 1 pages, it will order its pages by the dock_pos of their corresponding panes
  2. however, when drag a page on an automatic notebook, the notebook will not change its dock_pos (notebook does not know anything about the pane of its page)

One potential fix may be

  1. when UpdateNotebook() is called,
    1. when multiple pages are added to a same notebook, order them by their dock_pos (e.g., so after LoadPerspective(), the pages order are correct. )
    2. otherwise, do not check and re-order automatic notebook pages
  2. In LayoutAll() (~line 6185), if a pane is a notebook page, set its dock_pos to the page index in the notebook

2018-06-12_22-22-01

@tianzhuqiao

This comment has been minimized.

tianzhuqiao commented Jun 17, 2018

After the change

2018-06-16_21-32-48

@RobinD42

This comment has been minimized.

Member

RobinD42 commented Jun 23, 2018

Fixed by #885

@RobinD42 RobinD42 closed this Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment