Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with Python 3.8 on Linux #1227

Merged
merged 1 commit into from May 19, 2019

Conversation

Projects
None yet
2 participants
@swt2c
Copy link
Contributor

commented May 18, 2019

In Python 3.8, running "python3-config --libs" no longer returns the python
library itself. This causes Waf's pyembed check to fail as it can't resolve
references to methods in the python library. There is discussion[1] ongoing
about adding an "embed" mode to python3-config, but at the moment it is not
implemented. We can work around this, however, in wxPython, by invoking Waf's
check_python_headers() with just the "pyext" feature as "pyembed" isn't needed
in wxPython (as far as I can tell).

[1] https://bugs.python.org/issue36721

Fix building with Python 3.8 on Linux
In Python 3.8, running "python3-config --libs" no longer returns the python
library itself.  This causes Waf's pyembed check to fail as it can't resolve
references to methods in the python library.  There is discussion[1] ongoing
about adding an "embed" mode to python3-config, but at the moment it is not
implemented.  We can work around this, however, in wxPython, by invoking Waf's
check_python_headers() with just the "pyext" feature as "pyembed" isn't needed
in wxPython (as far as I can tell).

[1] https://bugs.python.org/issue36721
@RobinD42

This comment has been minimized.

Copy link
Member

commented May 19, 2019

Thanks, I've been meaning to check if this is possible for some other reasons as well.

@RobinD42 RobinD42 merged commit c74a933 into wxWidgets:wxPy-4.0.x May 19, 2019

4 checks passed

ci/circleci: Python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: Python-3.5 Your tests passed on CircleCI!
Details
ci/circleci: Python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: Python-3.7 Your tests passed on CircleCI!
Details

RobinD42 added a commit to RobinD42/Phoenix that referenced this pull request May 20, 2019

Merge pull request wxWidgets#1227 from swt2c/fix_build_python3.8
Fix building with Python 3.8 on Linux

(cherry picked from commit c74a933)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.