Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlay crash #1301

Merged
merged 3 commits into from Jul 9, 2019

Conversation

@RobinD42
Copy link
Member

RobinD42 commented Jul 9, 2019

Let wx.DCOverlay hold a reference to the dc to ensure it is not GC'ed first.

@RobinD42 RobinD42 merged commit de4d1d8 into master Jul 9, 2019
11 checks passed
11 checks passed
wxWidgets.Phoenix Build #CI.20190708..2 succeeded
Details
wxWidgets.Phoenix (Linux CI Py27) Linux CI Py27 succeeded
Details
wxWidgets.Phoenix (Linux CI Py36) Linux CI Py36 succeeded
Details
wxWidgets.Phoenix (Linux CI Py37) Linux CI Py37 succeeded
Details
wxWidgets.Phoenix (MacOS CI Py27) MacOS CI Py27 succeeded
Details
wxWidgets.Phoenix (MacOS CI Py36) MacOS CI Py36 succeeded
Details
wxWidgets.Phoenix (MacOS CI Py37) MacOS CI Py37 succeeded
Details
wxWidgets.Phoenix (Windows CI Py36_x64) Windows CI Py36_x64 succeeded
Details
wxWidgets.Phoenix (Windows CI Py36_x86) Windows CI Py36_x86 succeeded
Details
wxWidgets.Phoenix (Windows CI Py37_x64) Windows CI Py37_x64 succeeded
Details
wxWidgets.Phoenix (Windows CI Py37_x86) Windows CI Py37_x86 succeeded
Details
@RobinD42 RobinD42 deleted the fix-overlay-crash branch Jul 9, 2019
RobinD42 added a commit that referenced this pull request Sep 14, 2019
Fix overlay crash

(cherry picked from commit de4d1d8)
@RobinD42 RobinD42 referenced this pull request Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.