Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlay crash #1301

Merged
merged 3 commits into from Jul 9, 2019
Merged

Fix overlay crash #1301

merged 3 commits into from Jul 9, 2019

Conversation

RobinD42
Copy link
Member

@RobinD42 RobinD42 commented Jul 9, 2019

Let wx.DCOverlay hold a reference to the dc to ensure it is not GC'ed first.

@RobinD42 RobinD42 merged commit de4d1d8 into master Jul 9, 2019
11 checks passed
@RobinD42 RobinD42 deleted the fix-overlay-crash branch Jul 9, 2019
RobinD42 added a commit that referenced this issue Sep 14, 2019
Fix overlay crash

(cherry picked from commit de4d1d8)
@RobinD42 RobinD42 mentioned this pull request Sep 14, 2019
@RobinD42
Copy link
Member Author

@RobinD42 RobinD42 commented Apr 24, 2020

This pull request has been mentioned on Discuss wxPython. There might be relevant details there:

https://discuss.wxpython.org/t/wxpython-4-1-0-released/34564/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant