Preserve bytes immutability.
#1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nanosvg` modifies its input strings in place (see: https://github.com/wxWidgets/nanosvg/blob/9dd92bbfc6f709e889578a724724ffbd42ac3004/src/nanosvg.h#L348), which will lead to issues attempting to use the same python `bytes` object multiple times. Since bytes objects promise immutability its undesirable to permit them to be modified like this. To correct for this, we'll copy the bytes object into a new location in memory and pass that new memory location to nanosvg.
|
This pull request has been mentioned on Discuss wxPython. There might be relevant details there: https://discuss.wxpython.org/t/wxpython-4-1-1-released/35043/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nanosvgmodifies its inputchararrays in place (see: https://github.com/wxWidgets/nanosvg/blob/9dd92bbfc6f709e889578a724724ffbd42ac3004/src/nanosvg.h#L348),which will lead to issues attempting to use the same python
bytesobject multiple times. Since bytes objects promise immutability its undesirable to permit them to be modified like this.To correct for this, we'll copy the bytes object into a new location in memory and pass that new memory location to nanosvg.