Simplify building with MinGW toolchain #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a waf option `--no_msvc` that switches from a MSVC toolchain to a MinGW toolchain on Windows.
|
I'll merge this, but it would also be good to add a flag for build.py so it will also use MinGW to build wxWidgets, and also pass your new --no_msvc flag to waf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC, Phoenix is built with a MSVC toolchain on Windows by default.
While it is also possible to build it with a MinGW toolchain, this requires that some files of the build system are modified manually. The files that need changes include
wscriptandbuildtools/config.py.To simplify building with a MinGW toolchain a little bit, add a new option
--no_msvcforwafthat switches from a MSVC toolchain to a MinGW toolchain on Windows.Without that option, the MSVC toolchain continues to be used on Windows. So by default, MSVC is used like before this change.