IntCtrl: Change default colour to wx.NullColour #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wxWidgets#2199. The problem is that the default colour is currently wx.BLACK which will basically be invisible if the user has a dark theme. Use ``wx.NullColour`` instead so that it can just use the default text colour for the user's theme. Note that this does not fix the second part of issue wxWidgets#2199 (the colours still don't change if the control is disabled) but I feel this should be a separate issue now.
|
Ping ping? Any chance of a review for this? 😄 It's a fairly trivial change but I think it's a good one! Looking at the CI failures, it seems to have nothing to do with the PR and seems to be some generic Windows problem. It seems I don't have the authority to trigger a rerun of tests, but this might fix the issue.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2199.
The problem is that the default colour is currently wx.BLACK which will basically be invisible if the user has a dark theme. Use
wx.NullColourinstead so that it can just use the default text colour for the user's theme.Note that this does not fix the second part of issue #2199 (the colours still don't change if the control is disabled) but I feel this should be a separate issue now.