New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customtreectrl enhancement to have Window on CustomTreeItem on left of text #886

Merged
merged 4 commits into from Sep 25, 2018

Conversation

Projects
None yet
3 participants
@HelioGuilherme66
Copy link
Contributor

HelioGuilherme66 commented Jun 17, 2018

Adds a the parameter on_the_right, defaulted True, to allow positioning the Window in a CustomTreeItem.

[x] - Updated Demo - To see these changes expand item Hello World
- Added a Checkbox to set Window on the left (Unchecked by default)
- To update the Window on the desired position (Play/Pause image) must enable TREE_ITEM_EXPANDING
- To hide these Windows must enable TREE_ITEM_COLLAPSING
- To update the Window with the animated GIF (Recording image) on the desired position must enable TREE_ITEM_CHECKED

This is the same as #828 but for wxPy-4.0.x

@RobinD42

This comment has been minimized.

Copy link
Member

RobinD42 commented Jun 23, 2018

Is this complete? The CustomTreeCtrl sample in the demo doesn't seem to be doing anything different when the option is changed. The Play/Pause images are always displayed on the right of the label. (At least on OSX.)

@HelioGuilherme66

This comment has been minimized.

Copy link
Contributor

HelioGuilherme66 commented Jun 24, 2018

Sorry @RobinD42, no it is not complete. I'll change the title with WIP prefix.

@HelioGuilherme66 HelioGuilherme66 changed the title Customtreectrl enhancement to have Window on CustomTreeItem on left of text [WIP] Customtreectrl enhancement to have Window on CustomTreeItem on left of text Jun 24, 2018

@HelioGuilherme66 HelioGuilherme66 changed the title [WIP] Customtreectrl enhancement to have Window on CustomTreeItem on left of text Customtreectrl enhancement to have Window on CustomTreeItem on left of text Jul 1, 2018

@HelioGuilherme66

This comment has been minimized.

Copy link
Contributor

HelioGuilherme66 commented Jul 1, 2018

@RobinD42 I consider this done now.

@HelioGuilherme66

This comment has been minimized.

Copy link
Contributor

HelioGuilherme66 commented Jul 4, 2018

@infinity77 @RobinD42 Would you care to Review this?

@mesalu mesalu added the needs-review label Jul 9, 2018

@RobinD42
Copy link
Member

RobinD42 left a comment

  • Please add an item to the CHANGES.rst file describing this new feature.

  • It would be very nice if the demo could do a live update of the window position when the "Use Image Window Left of Label" option is toggled, like the rest of the options do. It took me a while to figure out that I had to expand or collapse the item to see the change, and item 1-f-4 never changes, despite using the flag when adding the window.

Version 2.6
Version 2.6.1

This comment has been minimized.

@RobinD42

RobinD42 Jul 13, 2018

Member

This is a significant new feature, so I would call it version 2.7.

Adds a the parameter `on_the_right`, defaulted True,
to allow positioning the Window in a CustomTreeItem.

Changed CustomTreeCtrl.py (demo) to show image on right or left of text.
Addded an animated gif to a checkbox item.
To test SetItemWindow new parameter on_the_right, just activate/deactivate
the "Use image Window left of label" checkbox on left panel.

Updated documentation and version.

@HelioGuilherme66 HelioGuilherme66 force-pushed the HelioGuilherme66:40xcustomtreectrl branch from 9d6d200 to 83d729c Aug 9, 2018

@HelioGuilherme66
Copy link
Contributor

HelioGuilherme66 left a comment

@RobinD42
Done all the requested changes.
(it was challenging)
Thanks.

@RobinD42 RobinD42 removed the needs-review label Sep 25, 2018

@RobinD42 RobinD42 merged commit 8a01142 into wxWidgets:wxPy-4.0.x Sep 25, 2018

3 checks passed

ci/circleci: Python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: Python-3.5 Your tests passed on CircleCI!
Details
ci/circleci: Python-3.6 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment