New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: list dependency on PIL used in a few wx.lib.agw modules #908

Merged
merged 1 commit into from Jul 4, 2018

Conversation

Projects
None yet
3 participants
@carandraug
Copy link
Contributor

carandraug commented Jul 2, 2018

As discussed on IRC, here's a pull request that adds PIL as list of dependencies.

@Metallicow

This comment has been minimized.

Copy link
Contributor

Metallicow commented Jul 4, 2018

@carandraug is this just for wx.lib.agw.shapedbutton? If so... I might look at the code and see if I can make a fix so it only imports if Pillow is installed.
My ShapedBitmapButton widget found here https://github.com/Metallicow/MCOW doesnt use PIL/Pillow.
For a moment I thought this was for thumbnailCtrl...

@carandraug

This comment has been minimized.

Copy link
Contributor

carandraug commented Jul 4, 2018

is this just for wx.lib.agw.shapedbutton?

Yes. It is also an optional dependency of wx/lib/agw/thumbnailctrl and wx/lib/agw/rulerctrl

@RobinD42 RobinD42 merged commit 3723bcc into wxWidgets:master Jul 4, 2018

3 checks passed

ci/circleci: Python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: Python-3.5 Your tests passed on CircleCI!
Details
ci/circleci: Python-3.6 Your tests passed on CircleCI!
Details

RobinD42 added a commit that referenced this pull request Jul 4, 2018

Merge pull request #908 from carandraug/master
setup.py: list dependency on PIL used in a few wx.lib.agw modules
(cherry picked from commit 3723bcc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment