Permalink
Switch branches/tags
Commits on Apr 29, 2017
  1. Merge branch 'pvs-fixes'

    Closes #470
    vadz committed Apr 29, 2017
  2. Don't send unnecessary events when wxSpinCtrlDouble loses focus

    Only send the event when the control loses focus if its value has really
    changed.
    
    Closes #436
    tommash committed with vadz Mar 15, 2017
  3. Fix wrong variable name in assignment in wxRichTextSizePage dtor

    The "sm_showMinMaxSizeControls" was assigned twice, while
    "sm_enablePositionAndSizeUnits" was not assigned at all, apparently by
    mistake.
    
    Thanks to PVS-Studio for finding this issue (V519 The
    'sm_showMinMaxSizeControls' variable is assigned values twice successively).
    IlyaPVS committed with vadz Apr 27, 2017
  4. Check for variable being non-NULL before using it

    The "buffer" argument can apparently be null, as there is a check for this on
    the next line, but it was used without checking that this is the case.
    
    Fix this, although it's not totally clear if "buffer" can really be null at
    all and maybe the check below should have been removed instead -- but prefer
    to err on the side of caution.
    
    Thanks to PVS-Studio for finding this issue (V595 The 'buffer' pointer was
    utilized before it was verified against nullptr).
    IlyaPVS committed with vadz Apr 27, 2017
  5. Use VARIANT_TRUE and VARIANT_FALSE correctly

    VARIANT_TRUE (-1) must be used with VARIANTs of boolean type, instead of TRUE
    (1) which has a different value and can result in interoperability problems.
    
    Thanks to PVS-Studio for finding this issue (V721 The VARIANT_BOOL type is
    utilized incorrectly).
    IlyaPVS committed with vadz Apr 27, 2017
  6. Fix check for wxACC_STATE_SYSTEM_MARQUEED in accessibility code

    wxACC_STATE_SYSTEM_INVISIBLE was checked twice, by mistake, while
    wxACC_STATE_SYSTEM_MARQUEED was never checked at all.
    
    Thanks to PVS-Studio for finding this issue (V581: The conditional expressions
    of the 'if' operators situated alongside each other are identical).
    IlyaPVS committed with vadz Apr 27, 2017
Commits on Apr 28, 2017
  1. Fix inserting multiple items to wxRearrangeList

    In wxRearrangeList implementations (like wxMSW) where DoInsertItemsInLoop()
    and DoInsertOneItem() are not used to insert multiple items, DoInsertItems()
    has to be overriden to do this insertion.
    
    See #17836.
    a-wi committed Apr 28, 2017
  2. Update mailmap file

    a-wi committed Apr 28, 2017
  3. Add demonstration of wxRearrangeList to widgets sample

    Add wxRearrangeList as another option on wxListBox page.
    a-wi committed Apr 28, 2017
  4. Order array has to have the same size as item list in wxRearrangeList

    Number of indices stored in the internal order array has to be the same as
    number of the items, so whenever item is added or removed, order array
    has to be adjusted accordingly.
    
    Closes #17836.
    a-wi committed Apr 28, 2017
Commits on Apr 26, 2017
  1. Fix keyboard event key codes when using Wayland

    Correct the confusion between compile- and run-time checks for X11.
    
    Closes #17848.
    vadz committed Apr 26, 2017
  2. Fix build problem with "override" on wxApp::GetXVisualInfo()

    This method doesn't override any virtual method in the base class, so
    wxOVERRIDE can't be used here.
    
    In fact, this method doesn't seem to be used at all, but keep it for
    compatibility and in case we want to use it later, as wxGTK does.
    vadz committed Apr 26, 2017
  3. make compile work again when wxUSE_UNICODE is not defined

    joukj committed Apr 26, 2017
Commits on Apr 25, 2017
  1. Fix displaying labels of wxRadioBox items

    Labels containing mnemonic prefixes (&) and literal underscore characters
    have to be converted to the proper GTK labels where underscore
    characters act as mnemonic markers. If label contains mnemonic then
    dedicated function gtk_radio_button_new_with_mnemonic() should be used
    to create radio button item.
    
    Closes #17419.
    a-wi committed Apr 25, 2017
  2. Fix the integer value in events generated by generic wxSpinCtrl

    This notably fixes the problem with changing the year using spin control
    arrows under macOS, where this control is used as part of
    wxGenericCalendarCtrl, as not having the correct value in the event object
    resulted in bogus events with dates in the year 0 there.
    
    Closes http://trac.wxwidgets.org/ticket/17193
    lanurmi committed with vadz Apr 14, 2017
  3. Synchronize setup for OpenVMS

    joukj committed Apr 25, 2017
Commits on Apr 23, 2017
  1. Fix wxMotif build after recent argv changes

    Update wxMotif too after 70a499f.
    vadz committed Apr 23, 2017
  2. Always use wxGTK, not wxMotif, by default under Unix systems

    wxMotif is not in a shape to be really for anything currently.
    vadz committed Apr 23, 2017
  3. Add WebKit2 description to docs

    sjlamerton committed Apr 22, 2017
Commits on Apr 22, 2017
  1. Add support for WebKit2GTK+ in wxWebView

    swt2c committed with sjlamerton Mar 31, 2017
  2. Add instructions for checking ABI compatibility to release HOWTO

    Explain how to use abi-compliance-checker.
    vadz committed Apr 22, 2017
Commits on Apr 20, 2017
  1. Merge branch 'xlocale-checks'

    Fix build on systems which don't have full x-locale support even though they
    do have <xlocale.h>, such as OpenIndiana.
    
    Closes #461
    vadz committed Apr 20, 2017
  2. Rename wx_cv_use_xlocale_local to wx_cv_func_strtod_l

    No real changes, just use more standard naming convention for a variable
    containing the cached value in configure.
    vadz committed Apr 20, 2017
Commits on Apr 19, 2017
  1. Use symbolic constant for DST shift

    No real changes, just use DST_OFFSET constant instead of 3600 and remove the
    "FIXME" comments as we're not actually going to fix anything here but will
    just continue to assume 1 hour shift for DST.
    vadz committed Apr 18, 2017
  2. Revert wrong fix for wxDateTime timezone conversion to/from local

    This reverts commit aaddf6b as it broke
    handling of dates when local time zone is BST, whose offset not counting DST
    is 0, as for UTC, but which still should be handled as local timezone,
    see #17220.
    
    With the current wxDateTime handling of time zones, FromTimezone(Local)
    doesn't make much sense anyhow, so abandon attempts to try making it work as
    to really do it we need to specify the time zone being converted from too, as
    explained in the second point of #10445.
    
    See #16585.
    vadz committed Apr 19, 2017
  3. Fix wrong example using printf() in wxDateTime overview

    Use wxPrintf() and remove the c_str() call which is redundant with it instead
    of using printf() which can't be used with non-POD objects like wxCStrData
    returned by c_str() in wx 3.0+.
    vadz committed Apr 18, 2017
  4. Determine availability of the required xlocale API by compiling

    Even if <xlocale.h> exists, the whole API that wx requires (specifically
    strtod_l() and similar) may not be available. This is the case
    on e.g. OpenIndiana (SunOS).
    lanurmi committed Apr 14, 2017
  5. Compile the check for ICONV_CONST as C++

    On OpenIndiana (SunOS) the result is different when compiled as C,
    and the C++ result is what matters to wxWidgets.
    
    Fixes compilation of src/common/strconv.cpp on OpenIndiana.
    lanurmi committed Apr 6, 2017
Commits on Apr 18, 2017
  1. Fix "ont" (instead of "one") typo in wxSTC

    Correct "ont" to "one" in several places.
    Metallicow committed with vadz Apr 18, 2017
  2. Update selection in wxAuiNotebook correctly after tab move

    Update the selected state of the tab with the index corresponding to the old
    index of the tab which was moved.
    
    Closes #16605.
    jensgoe committed with vadz Jan 11, 2016
Commits on Apr 17, 2017
  1. Change current font only if new graphics font is successfully created

    If new graphics font couldn't be created successfully there is no need
    to reset current font by updating it to wxNullGraphicsFont.
    
    Closes #17790.
    a-wi committed Apr 17, 2017
  2. Handle unsuccessful creation of graphics font in Direct2D

    Apparently, DirectWrite fonts can be created only from TrueType fonts and
    therefore only such fonts can be used with Direct2D-based wxGraphicsContext.
    When unsuported GDI font is passed to CreateFont() then no graphics font is
    created and this unsuccessful attempt is signalled by returning
    wxNullGraphicsFont. This null object can be used in e.g. wxGC::SetFont()
    to check if font was actually created.
    
    See #17790.
    a-wi committed Apr 17, 2017
Commits on Apr 16, 2017
  1. Fix fatal bug in the last commit: restore setting argc

    Initialization of wxApp::argc was mistakenly removed, breaking the code
    iterating over wxApp::argv from 0 to it.
    
    See #462
    vadz committed Apr 16, 2017
  2. Don't rely on argv being NULL-terminated under MSW

    Since the changes of c9a458b ("Use Win32
    ::CommandLineToArgvW() to tokenize command line"), this is not guaranteed any
    more as this Win32 function doesn't necessarily ensure it under older MSW
    versions such as XP.
    
    Just use "argc" explicitly instead of relying on this in wxCmdLineArgsArray to
    fix crashing under XP.
    vadz committed Apr 14, 2017
  3. Add autoconf support for building with SDL2

    Adds support for finding SDL2 when running configure (support for actually
    using SDL2 was added back in cb50bdc).
    swt2c committed with vadz Apr 16, 2017