Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxRichTextCtrl: Drawing the selection doesn't respect its container #15520

Closed
wxtrac opened this issue Sep 18, 2013 · 4 comments
Closed

wxRichTextCtrl: Drawing the selection doesn't respect its container #15520

wxtrac opened this issue Sep 18, 2013 · 4 comments
Labels

Comments

@wxtrac
Copy link
Collaborator

@wxtrac wxtrac commented Sep 18, 2013

Issue migrated from trac ticket # 15520

component: wxRichText | priority: normal | resolution: fixed | keywords: wxRichTextParagraphLayoutBox::Draw selection

2013-09-18 22:28:06: @dghart created the issue


In wxRichTextCtrl, drawing selected text is done in different colours to unselected; for me, it's white on blue. However wxRichTextParagraphLayoutBox::Draw doesn't adequately restrict this. As can be seen in the diff to the richtext sample and the attached screenshot, if position n is selected, cell n of a following table will also be selected (you may have to scroll to force a refresh before it's visible).

This is fixed by richtextbuffer.patch.

@wxtrac
Copy link
Collaborator Author

@wxtrac wxtrac commented Sep 18, 2013

2013-09-18 22:28:50: @dghart uploaded file sample.diff (1.5 KiB)

@wxtrac
Copy link
Collaborator Author

@wxtrac wxtrac commented Sep 18, 2013

2013-09-18 22:29:01: @dghart uploaded file Screenshot.png (19.3 KiB)

Screenshot.png

@wxtrac
Copy link
Collaborator Author

@wxtrac wxtrac commented Sep 18, 2013

2013-09-18 22:29:13: @dghart uploaded file richtextbuffer.patch (0.7 KiB)

@wxtrac
Copy link
Collaborator Author

@wxtrac wxtrac commented Sep 19, 2013

2013-09-19 09:48:36: @JulianSmart changed status from new to closed

2013-09-19 09:48:36: @JulianSmart set resolution to fixed

2013-09-19 09:48:36: @JulianSmart commented

Thank you, now applied.

@wxtrac wxtrac closed this Sep 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant