Grid and tabs on rasberry pi and other unix platforms with dark themes is unreadable #18941
Issue migrated from trac ticket # 18941
component: GUI-all | priority: normal | resolution: fixed | keywords: regression
2020-10-13 03:16:52: mgrouch created the issue
Uses white fonts over white backgrounds
The text was updated successfully, but these errors were encountered:
2020-10-13 03:55:51: mgrouch commented
Maybe choosing the font color should be based on the background of the theme
Here is more info on RGB luminance
might be the font needs to invert it given color of background automatically?
It either needs to trust background color of the theme or foreground.
I think the whole theme colors can't be trusted cause user might have set
Might be do automatic optimization so it even always shows up fine on print outs in grayscale. It might use background color as a base and foreground as a hint for optimization
into consideration that some people are color blind too.
2020-10-13 19:54:24: mgrouch commented
sudo apt install breeze-gtk-theme breeze-icon-theme breeze-icon-theme breeze-icon-theme-rcc breeze-cursor-theme
Change theme to 'Breeze-Dark'
Grids with selections
White on white in grids
2020-10-15 19:00:19: @vadz commented
This is the patch which I mentioned in comment:6. It wasn't applied because it still doesn't work under Linux (not sure if it makes things worse, but they're definitely not right with this change) and I hope to fix them there too.
2020-10-19 23:41:53: mgrouch changed priority from normal to high
2020-10-19 23:41:53: mgrouch changed title from Grid on rasberry pi with dark themes is unreadable to Grid and tabs on rasberry pi and other unix platforms with dark themes is unreadable
2020-10-20 03:25:52: mgrouch commented
It is possible that application doing something wrong.
As a first attempt what if we before rendering text in these two
If they are too close we will only change font color to something readable,
I'll lookup formulas for RGB conversion to grays cale.
(assuming r,g,b are in range of 0 to 255)
And add a flag to turn off this logic. On Grid and Tabs.
Just an idea.
2021-02-11 21:36:01: @discnl changed status from infoneeded_new to new
2021-02-11 21:36:01: @discnl commented
As hinted at, under MSW the highlight is pretty much invisible now.
Both the referred to
2021-05-19 19:42:59: @vadz changed component from wxGTK to GUI-all
2021-05-19 19:42:59: @vadz commented
Replying to [comment:8 dkulp]:
FWIW, the reason it wasn't applied was because I was not sure it wasn't going to break something under the other platforms and I was wrong to apply it without testing it myself because it did totally break wxMSW, see #19179 (also mentioned in the comment:17 but I didn't realize just how bad it was).