Fix appearance of wxTextCtrl with wxTE_RICH in dark mode in wxMSW - #25602
Merged
Conversation
Rich text controls still had light appearance, fix this and use the same colours for them as for the plain EDIT ones in dark mode. See wxWidgets#25573. Closes wxWidgets#25576.
There is no need to call it only to pass to MSWCreateControl() overload taking it when we can use another, simpler, overload which determines the flags and extended flags to use itself -- and so calls MSWGetStyle() only once instead of doing it twice as before, as it was still called from MSWCreateControl() to fill in the extended style. No real changes, this is just a micro-optimization.
For some reason the native RICHEDIT50W control automatically adds WS_EX_CLIENTEDGE if the control has a border, and this looks ugly in dark mode, so remove this extended style if it's present.
This was referenced Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use correct (the same as for plain
EDIT) colours for it and also fix the border.