Repository navigation
Make wxNumberFormatter's helper functions publically available - #25614
Closed
Blake-Madden wants to merge 5 commits into
Closed
Blake-Madden wants to merge 5 commits into
Blake-Madden wants to merge 5 commits into
Conversation
Contributor
|
I'm not sure about the thousands separators functions, we may need to change their signature if #1781 is finally merged, so I'd rather not make them public now. |
Contributor
Author
|
Only |
Contributor
|
Thanks, will merge soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No real changes, just exposes
wxNumberFormatter'sAddThousandsSeparators,RemoveThousandsSeparators, andRemoveTrailingZeroespublicly.I could use
RemoveTrailingZeroes()myself for cleaning up strings from my data importer, and IMO there is real value is making these functions available.