Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use cjs for browser fields #1555

Merged
merged 1 commit into from Sep 20, 2019

Conversation

@paulfalgout
Copy link
Contributor

commented Sep 19, 2019

We should not be using pre-built files for the browser. Resolves #1553

We should not be using pre-built files for the `browser`.  Resolves #1553
@paulfalgout

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2019

Related to #1540
@ouijan I think this PR is a nonbreaking solution with similar, perhaps improved, results for the issue you were seeing with imports. While I think the packaged min.js file may function in some cases, it's breaking in others... But I think these cjs cover your case and the general. If you don't mind 👀 on this.

@nknapp nknapp merged commit c55a7be into wycats:4.x Sep 20, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.