Enabling custom template extension #349

Merged
merged 1 commit into from Apr 7, 2013

Conversation

Projects
None yet
5 participants
Contributor

matteoagosti commented Oct 23, 2012

Hi guys, when working out with express.js and its connect handlebars module, I find extremely useful to work with hbs extension because it keeps everything shorter and is the default one.
However, when adding custom build scripts to precompile templates I find it annoying as the hbs extension remains in the template name.

With this commit I added an additional, optional, parameter to specify the template extension so that it could get easily removed from template name. The parameter has its default value set to handlebars as to be consistent with the current implementation.

Thank you for your great work!

Owner

wycats commented Oct 23, 2012

It seems like you would want to regex escape the extension before passing it into new RegExp?

Collaborator

wagenet commented Nov 2, 2012

@matteoagosti Can you squash these two commits together?

Contributor

matteoagosti commented Nov 8, 2012

Done! I apologize for the delay.

arian commented Apr 3, 2013

👍

kpdecker merged commit 53d6b4c into wycats:master Apr 7, 2013

1 check passed

default The Travis build passed
Details
Collaborator

kpdecker commented Apr 7, 2013

Merged and added escape for arg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment