Fix spec for 8df8488 #405

Merged
merged 1 commit into from Jan 13, 2013

Conversation

Projects
None yet
3 participants
@leshill
Contributor

leshill commented Jan 6, 2013

The build was broken by the changes to the log helper.

@wycats

This comment has been minimized.

Show comment Hide comment
@wycats

wycats Jan 6, 2013

Owner

Why is the travis build still failing with this change?

Owner

wycats commented Jan 6, 2013

Why is the travis build still failing with this change?

@leshill

This comment has been minimized.

Show comment Hide comment
@leshill

leshill Jan 6, 2013

Contributor

Hi @wycats,

bundle install is failing. I noted on my machine that there seems to be some instability with the Gemfile -- I got a few ruby stack traces, perhaps TRR should be updated to 0.11.1?

Contributor

leshill commented Jan 6, 2013

Hi @wycats,

bundle install is failing. I noted on my machine that there seems to be some instability with the Gemfile -- I got a few ruby stack traces, perhaps TRR should be updated to 0.11.1?

@kpdecker

This comment has been minimized.

Show comment Hide comment
@kpdecker

kpdecker Jan 8, 2013

Collaborator

0.11.1 did not do the trick. It looks like cowboyd/therubyracer#215 has quite a bit of discussion on this and is marked as closed but the travis specific portions do not seem to be resolved as best I can tell.

Right now it seems like reverting 28f377d is the easiest solution (and it fixes the performance issues with the ruby tests). @wycats do you see any issues with this while the upstream issues are being resolved?

Collaborator

kpdecker commented Jan 8, 2013

0.11.1 did not do the trick. It looks like cowboyd/therubyracer#215 has quite a bit of discussion on this and is marked as closed but the travis specific portions do not seem to be resolved as best I can tell.

Right now it seems like reverting 28f377d is the easiest solution (and it fixes the performance issues with the ruby tests). @wycats do you see any issues with this while the upstream issues are being resolved?

@leshill

This comment has been minimized.

Show comment Hide comment
@leshill

leshill Jan 8, 2013

Contributor

+1 for the temporary rollback.

Contributor

leshill commented Jan 8, 2013

+1 for the temporary rollback.

@kpdecker

This comment has been minimized.

Show comment Hide comment
@kpdecker

kpdecker Jan 13, 2013

Collaborator

Temporary fix here f671c2e

Collaborator

kpdecker commented Jan 13, 2013

Temporary fix here f671c2e

@wycats

This comment has been minimized.

Show comment Hide comment
@wycats

wycats Jan 13, 2013

Owner

@kpdecker no problem here :)

Owner

wycats commented Jan 13, 2013

@kpdecker no problem here :)

@wycats

This comment has been minimized.

Show comment Hide comment
@wycats

wycats Jan 13, 2013

Owner

@kpdecker can you try 0.11.2?

Owner

wycats commented Jan 13, 2013

@kpdecker can you try 0.11.2?

@kpdecker kpdecker merged commit f4cad08 into wycats:master Jan 13, 2013

1 check failed

default The Travis build failed
Details
@kpdecker

This comment has been minimized.

Show comment Hide comment
@kpdecker

kpdecker Jan 13, 2013

Collaborator

I can't seem to install 0.11.2 on my system :/

/opt/local/lib/ruby/gems/1.8/gems/libv8-3.11.8.13/ext/libv8/location.rb:50:in `configure': You have chosen to use the version of V8 found on your system (Libv8::Location::System::NotFoundError)
and not the one that is bundle with the libv8 rubygem. However,
it could not be located. please make sure you have a version of
v8 that is compatible with 3.11.8.13 installed. You may
need to special --with-v8-dir options if it is in a non-standard
location

thanks,
The Mgmt

from /opt/local/lib/ruby/gems/1.8/gems/libv8-3.11.8.13/lib/libv8.rb:7:in `configure_makefile'
from extconf.rb:27

I'm not familiar with Ruby packaging so I'm not really sure how to debug this nor does it feel like it's going to work easily on other systems if the system v8 option is used.

Collaborator

kpdecker commented Jan 13, 2013

I can't seem to install 0.11.2 on my system :/

/opt/local/lib/ruby/gems/1.8/gems/libv8-3.11.8.13/ext/libv8/location.rb:50:in `configure': You have chosen to use the version of V8 found on your system (Libv8::Location::System::NotFoundError)
and not the one that is bundle with the libv8 rubygem. However,
it could not be located. please make sure you have a version of
v8 that is compatible with 3.11.8.13 installed. You may
need to special --with-v8-dir options if it is in a non-standard
location

thanks,
The Mgmt

from /opt/local/lib/ruby/gems/1.8/gems/libv8-3.11.8.13/lib/libv8.rb:7:in `configure_makefile'
from extconf.rb:27

I'm not familiar with Ruby packaging so I'm not really sure how to debug this nor does it feel like it's going to work easily on other systems if the system v8 option is used.

JamesMaroney pushed a commit to tnwinc/handlebars.js that referenced this pull request May 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment