Skip to content
This repository

Fix spec for 8df8488 #405

Merged
merged 1 commit into from over 1 year ago

3 participants

Les Hill Yehuda Katz Kevin Decker
Les Hill

The build was broken by the changes to the log helper.

Yehuda Katz
Owner

Why is the travis build still failing with this change?

Les Hill

Hi @wycats,

bundle install is failing. I noted on my machine that there seems to be some instability with the Gemfile -- I got a few ruby stack traces, perhaps TRR should be updated to 0.11.1?

Kevin Decker
Collaborator

0.11.1 did not do the trick. It looks like cowboyd/therubyracer#215 has quite a bit of discussion on this and is marked as closed but the travis specific portions do not seem to be resolved as best I can tell.

Right now it seems like reverting 28f377d is the easiest solution (and it fixes the performance issues with the ruby tests). @wycats do you see any issues with this while the upstream issues are being resolved?

Les Hill

+1 for the temporary rollback.

Kevin Decker
Collaborator

Temporary fix here f671c2e

Yehuda Katz
Owner

@kpdecker no problem here :)

Yehuda Katz
Owner

@kpdecker can you try 0.11.2?

Kevin Decker kpdecker merged commit f4cad08 into from January 13, 2013
Kevin Decker kpdecker closed this January 13, 2013
Kevin Decker
Collaborator

I can't seem to install 0.11.2 on my system :/

/opt/local/lib/ruby/gems/1.8/gems/libv8-3.11.8.13/ext/libv8/location.rb:50:in `configure': You have chosen to use the version of V8 found on your system (Libv8::Location::System::NotFoundError)
and not the one that is bundle with the libv8 rubygem. However,
it could not be located. please make sure you have a version of
v8 that is compatible with 3.11.8.13 installed. You may
need to special --with-v8-dir options if it is in a non-standard
location

thanks,
The Mgmt

from /opt/local/lib/ruby/gems/1.8/gems/libv8-3.11.8.13/lib/libv8.rb:7:in `configure_makefile'
from extconf.rb:27

I'm not familiar with Ruby packaging so I'm not really sure how to debug this nor does it feel like it's going to work easily on other systems if the system v8 option is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jan 06, 2013
Les Hill Fix spec for 8df8488 f4cad08
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 3 additions and 2 deletions. Show diff stats Hide diff stats

  1. 5  spec/qunit_spec.js
5  spec/qunit_spec.js
@@ -764,12 +764,13 @@ test("log", function() {
764 764
   var string = "{{log blah}}";
765 765
   var hash   = { blah: "whee" };
766 766
 
767  
-  var logArg;
  767
+  var levelArg, logArg;
768 768
   var originalLog = Handlebars.log;
769  
-  Handlebars.log = function(arg){ logArg = arg; };
  769
+  Handlebars.log = function(level, arg){ levelArg = level, logArg = arg; };
770 770
   teardown = function(){ Handlebars.log = originalLog; };
771 771
 
772 772
   shouldCompileTo(string, hash, "", "log should not display");
  773
+  equals(1, levelArg, "should call log with 1");
773 774
   equals("whee", logArg, "should call log with 'whee'");
774 775
 });
775 776
 
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.