Amd module return values #488

Merged
merged 2 commits into from Apr 8, 2013

Conversation

Projects
None yet
3 participants
@JamesMaroney
Contributor

JamesMaroney commented Apr 8, 2013

This is a rewrite of pull request #377

If building AMD module output and only one template/partial, return that compiled template as the module output. If building AMD module output and multiple templates/partials return the full hash of templates/partials.

JamesMaroney added some commits Apr 8, 2013

If building AMD modules, and only one template is being compiled,
return the compiled template from the AMD module
If building AMD module and compiling multiple templates, return the full
templates (or partials) hash from the AMD module

kpdecker added a commit that referenced this pull request Apr 8, 2013

@kpdecker kpdecker merged commit 4c35f89 into wycats:master Apr 8, 2013

1 check passed

default The Travis build passed
Details
@blessenm

This comment has been minimized.

Show comment Hide comment
@blessenm

blessenm May 15, 2013

Contributor

This seems to cause an issue when we specify a folder path as the input instead of filenames. I used the command like
handlebars templates/>templates.js -a -e html
And get an output file with return after every template in the folder.

Contributor

blessenm commented May 15, 2013

This seems to cause an issue when we specify a folder path as the input instead of filenames. I used the command like
handlebars templates/>templates.js -a -e html
And get an output file with return after every template in the folder.

@kpdecker

This comment has been minimized.

Show comment Hide comment
@kpdecker

kpdecker May 15, 2013

Collaborator

@blessenm Can you file a new bug for the issue you are seeing now?

Collaborator

kpdecker commented May 15, 2013

@blessenm Can you file a new bug for the issue you are seeing now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment